Closed Bug 1255911 Opened 8 years ago Closed 8 years ago

Subprocess markers in Talos SPS profiles are offset

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: mconley, Unassigned)

References

Details

Attachments

(1 file)

Here's a profile generated by a talos run with --spsProfile:

https://cleopatra.io/#report=6f8a4ba93e208406d7b22760474a851f23fdde8f&selection=0,1360,8,3,1362,1364,102

Those markers in the content process are positioned incorrectly - they should be clustering more around the spikes.

This was fixed in the Gecko Profiler Add-on in this patch: https://github.com/bgirard/Gecko-Profiler-Addon/commit/d1ab750a77b734e220da3c72acf8d352d0f23b96

We probably need to do something similar for the sps_profile.py stuff for Talos.
Comment on attachment 8733903 [details]
MozReview Request: Bug 1255911 - Offset subprocess profiler markers from Talos to match reality. r?mstange

https://reviewboard.mozilla.org/r/41999/#review38481

I'm unhappy about the fact that Benoit chose to do this in the addon instead of in cleopatra. But I guess we can still back this out if/when cleopatra changes.
Attachment #8733903 - Flags: review?(mstange) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0efb960a6400
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1354842
You need to log in before you can comment on or make changes to this bug.