Closed Bug 1255963 Opened 6 years ago Closed 6 years ago

Visual Studio warning detection fails to detect several warnings

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file)

As part of looking at logs in bug 1124033, I discovered that the warning detection code in `mach build` is failing to flag several warnings. I'm not sure if this has been broken for a while or if Visual Studio 2015 introduced new syntax.
I'm not sure when this changed, but at least Visual Studio 2015
doesn't always emit a space between the line number and the ": warning"
text in cl.exe output.

Making the space optional in the regular expression enables one a
VS2015 build to capture 375 warnings instead of 17. We still fail to
capture some warnings (notably generic warnings about bad command
arguments and linker warnings). But that can be dealt with later.

Review commit: https://reviewboard.mozilla.org/r/39589/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39589/
Attachment #8729797 - Flags: review?(mh+mozilla)
Attachment #8729797 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8729797 [details]
MozReview Request: Bug 1255963 - Detect warnings without space after line number; r?glandium

https://reviewboard.mozilla.org/r/39589/#review36465
Assignee: nobody → gps
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/0737c6bd21e6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.