1256028 - xpcom/io/nsLocalFileWin.cpp:1724 [C4477] '_snwprintf' : format string '%s' requires an argument of type 'wchar_t *', but variadic argument 3 has type 'char16ptr_t'

Status: RESOLVED FIXED

(Core :: Networking: File, defect)

Description

[Gregory Szorc [:gps]]

The warning in the summary is currently being suppressed by Visual Studio 2015. To reproduce it, remove "-Wv:18" from old-configure.in and rebuild.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1256028 - Disable C4477 to unblock compilation on VS2015; r?mcmanus

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/39939/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39939/

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8730488 [details]
MozReview Request: Bug 1256028 - Disable C4477 to unblock compilation on VS2015; r?mcmanus

https://reviewboard.mozilla.org/r/39939/#review36593

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdea1598a698

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cdea1598a698