1256056 - "Share this page" and "Downloads" buttons sometimes blink when I click them to open panel

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160310030242
STR:
1. Launch a new profile (just in case)
2. Move "Hello", "Share this page" and "Downloads" buttons to bookmarks toolbar
3. Open http://example.com/
4. Click "Hello", "Share this page" or "Downloads" button

AR:  Buttons blink "not_pressed -> pressed -> not_pressed -> pressed"
ER:  Shouldn't blink, just like other buttons that open panels: "not_pressed -> pressed"

Bug 1251902 made it less noticeable, but it still happens.
On the screencast, I wait ~1s between mousedown and mouseup to demonstrate the bug.
With "Share this page" it happened only for the 3st time. It's not 100% reproducible.

Comment 2

[:Gijs (he/him)]

Mark, any idea what could be causing this after your changes?

Comment 3

[Mark Banner (:standard8)]

(In reply to :Gijs Kruitbosch from comment #2)
> Mark, any idea what could be causing this after your changes?

Given this also seems to affect the downloads button, which afaik isn't using social, and delaying mousedown -> mouseup seems to make it worse, I would expect its something in the code for the button. Something how they're linked or deal with the open attribute.

Comment 4

[arni2033]

(In reply to Mark Banner (:standard8) from comment #3)
> delaying mousedown -> mouseup seems to make it worse
It doesn't make it worse, I just said that because the same screencast could be recorded if I quickly doubleclicked some buttons (which wouldn't be a bug then).
So I just clarified that all my clicks were relatively slow, and they blink exactly after mouseup.

Comment 5

[Mark Banner (:standard8)]

Dropping Hello from the list as that's been discontinued.