about:home (homepage) doesn't switch to overflowed mode when it's loaded in a narrow content area

VERIFIED FIXED in Firefox 48

Status

()

Firefox
General
VERIFIED FIXED
2 years ago
a year ago

People

(Reporter: arni2033, Assigned: Gijs)

Tracking

Trunk
Firefox 48
Points:
---

Firefox Tracking Flags

(firefox47 affected, firefox48 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160312030405
STR:
0. Launch new profile. Set firefox as default browser, set "When Nightly Starts" to "Show Homepage"
1. Open homepage (about:home) in a new tab, resize application window (or open bookmarks
   sidebar/history sidebar/some site in sidebar) so that homepage switched to overflow mode,
   but there still was no horizontal scrollbar
2. Restart firefox
3. Scroll the page to the righ using scrollbar

AR:
 Homepage hasn't switched to overflow mode, so all buttons are displayed horizontally.
 Downloads button is invisible. Background of "Restore Session" button is partially clipped

ER:  
 Homepage should switch to overflow mode, or at least all buttons including
 "Downloads" button should be fully visible if I scroll the page using scrollbar.
 Background of "Restore Previous Session" button should cover the whole button.
(Assignee)

Comment 1

2 years ago
Felipe, can you reproduce this?
Blocks: 1244221
Flags: needinfo?(felipc)
(Reporter)

Comment 3

2 years ago
STR:
(assuming comment 0 was scenario A, here're scenarios B,C,D)
0. Launch new profile. Set firefox as default browser, set "When Nightly Starts" to "Show Homepage"
1. Open homepage (about:home) in a new tab, resize window so that homepage switched to overflow mode
2.B) Press Ctrl+R (reload tab)
2.C) Open new tab, press Alt+Home (open homepage)
2.D) Open new tab, press Ctrl+W (close tab), then Ctrl+Shift+T (restore tab)


To clarify this:   I never use homepage as it became malicious after all those "enhancements".
But I sometimes test Nightly and it's pretty... sad to see this breakage.
Summary: about:home (homepage) doesn't switch to overflowed mode when I start Firefox even if content area is narrow enough → about:home (homepage) doesn't switch to overflowed mode when it's loaded in a narrow content area
(Assignee)

Updated

2 years ago
Flags: needinfo?(felipc)
(Assignee)

Comment 4

2 years ago
Created attachment 8737738 [details]
MozReview Request: Bug 1256165 - fit to width again after the restore session button is added, r?felipe

Review commit: https://reviewboard.mozilla.org/r/44101/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44101/
Attachment #8737738 - Flags: review?(felipc)
Comment on attachment 8737738 [details]
MozReview Request: Bug 1256165 - fit to width again after the restore session button is added, r?felipe

https://reviewboard.mozilla.org/r/44101/#review40679

Was this not a problem before bug 1244221 and bug 962249 ?
Attachment #8737738 - Flags: review?(felipc) → review+
(Reporter)

Comment 6

2 years ago
(In reply to :Felipe Gomes (needinfo me!) from comment #5)
> Was this not a problem before bug 1244221 and bug 962249 ?
The bug is presented since at least Release 20.

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b98bd60a5a87
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
(Assignee)

Updated

2 years ago
Assignee: nobody → gijskruitbosch+bugs
QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 48.0a1 (2016-03-12) on Windows 7 , 64 Bit!

But I could not see the fix on latest Beta 48.0b7 & latest Nightly

 Build ID   20160708004052
 User Agent  Mozilla/5.0 (Windows NT 6.1;Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

 Build ID   20160714030208
 User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
(Assignee)

Comment 10

2 years ago
(In reply to Maruf Rahman from comment #9)
> I have reproduced this bug with Nightly 48.0a1 (2016-03-12) on Windows 7 ,
> 64 Bit!
> 
> But I could not see the fix on latest Beta 48.0b7 & latest Nightly
> 
>  Build ID   20160708004052
>  User Agent  Mozilla/5.0 (Windows NT 6.1;Win64; x64; rv:49.0) Gecko/20100101
> Firefox/49.0
> 
>  Build ID   20160714030208
>  User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0)
> Gecko/20100101 Firefox/50.0

I just tried and it seems to work correctly for me when testing latest nightly on OS X, at least... arni, are you still able to reproduce this? Maruf, can you clarify what you're doing with a screencast or something like that?
Flags: needinfo?(maruf.rahman.95)
Flags: needinfo?(arni2033)
* If you resize the window in such a proportion that from the left side you sill only see the 'download' logo

* then if you try press ctrl+f then you will be able to see that the download logo has been compromised
*Which means the 'download' logo to some extend has been cut off by the left boundary of the browser window 

https://drive.google.com/open?id=0B75_JfziYeofck9RQVpHcHRnS00
https://drive.google.com/open?id=0B75_JfziYeofc3lYVlY5cjdsX1E
https://drive.google.com/open?id=0B75_JfziYeofdDNTb1oySUJpVXM
(Assignee)

Comment 12

2 years ago
(In reply to Maruf Rahman from comment #11)
> * If you resize the window in such a proportion that from the left side you
> sill only see the 'download' logo
> 
> * then if you try press ctrl+f then you will be able to see that the
> download logo has been compromised
> *Which means the 'download' logo to some extend has been cut off by the left
> boundary of the browser window 
> 
> https://drive.google.com/open?id=0B75_JfziYeofck9RQVpHcHRnS00
> https://drive.google.com/open?id=0B75_JfziYeofc3lYVlY5cjdsX1E
> https://drive.google.com/open?id=0B75_JfziYeofdDNTb1oySUJpVXM

But there's clearly room to move the scrollbar further to the left in the screenshot of the "cut off" downloads logo - it's just scrolled out of view, not permanently inaccessible like before. Plus, that screenshot doesn't seem to have a session restore button which was at the heart of this bug. It's really not clear to me what steps you're following and what you think the bug is.
(Reporter)

Comment 13

2 years ago
Affected:  Win7_64, Release 47,     32bit, ID 20160604131506
Fixed on:  Win7_64, Beta    48.0b6, 32bit, ID 20160706215822
Fixed on:  Win7_64, Nightly 50,     32bit, ID 20160714030208 (2016-07-14)

If I scroll with scrollbars, I can scroll each button into view, so that it was fully visible (no matter how narrow is content area).
I only mentioned clipped Downloads button, and clipped background of another button, because layout was a bit broken by "Restore session" button. The button was the root cause, it's fixed now.

Anyway, if somebody notices other bugs, they should be filed separately.
Status: RESOLVED → VERIFIED
status-firefox47: --- → affected
status-firefox48: fixed → verified
Flags: needinfo?(arni2033)
(Reporter)

Updated

2 years ago
QA Whiteboard: [good first verify]
I think the bug is the download logo cant't be seen if you resize the window from right to left the most you can and then search(ctrl+f)and write something in the search bar. I found the problem fixed in 48(Beta)
Flags: needinfo?(maruf.rahman.95)
You need to log in before you can comment on or make changes to this bug.