Closed Bug 1256227 Opened 8 years ago Closed 8 years ago

[TV][SYNC] Need last_modified information for Tabs sync feature

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.6?)

RESOLVED FIXED
blocking-b2g 2.6?

People

(Reporter: selee, Assigned: selee)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

Add last_modified property into Tabs sync record.
blocking-b2g: --- → 2.6?
Comment on attachment 8730093 [details] [review]
[gaia] weilonge:seanlee/DataSync/master/Bug1256227 > mozilla-b2g:master

Hey Michiel,

Could you help to review this patch? Thank you!
Attachment #8730093 - Flags: review?(mbdejong)
Out of curiosity, why do you need the timestamp? You already have lastUsed in the payload, right?
Flags: needinfo?(selee)
lastUsed is only for each tab single record (see here [1])
Based on UX's design, we need a timestamp to tell users when the devices' record is modified or updated.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/adapters/tabs.js#L287
Flags: needinfo?(selee)
Comment on attachment 8730093 [details] [review]
[gaia] weilonge:seanlee/DataSync/master/Bug1256227 > mozilla-b2g:master

r+wc, see https://github.com/mozilla-b2g/gaia/pull/34160#issuecomment-196220944
Attachment #8730093 - Flags: review?(mbdejong) → review+
landed on master: https://github.com/mozilla-b2g/gaia/commit/3c8d637561a5416f21b2af997baaedf2eb0a7d0c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: