Remove unused Distribution.getDescriptor()

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: Umesh Kumhar, Mentored)

Tracking

unspecified
Firefox 48
All
Android
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The getDescriptor() method of the Distribution class is unused.


To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

To fix this bug, you need to remove this method:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/distribution/Distribution.java#353-379

Then, you'll need to create a patch to upload - see
https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
(Assignee)

Comment 1

2 years ago
Created attachment 8730423 [details] [diff] [review]
1256236.patch

hi please review the patch.
(Reporter)

Comment 2

2 years ago
Comment on attachment 8730423 [details] [diff] [review]
1256236.patch

Thank you Umesh. Use the "review" flag on the attachment to get this reviewed. :)
Attachment #8730423 - Flags: review?(s.kaspari)
(Reporter)

Updated

2 years ago
Assignee: nobody → write2umeshkumhar
Status: NEW → ASSIGNED
(Reporter)

Comment 3

2 years ago
Comment on attachment 8730423 [details] [diff] [review]
1256236.patch

Review of attachment 8730423 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thank you, Umesh!
Attachment #8730423 - Flags: review?(s.kaspari) → review+
(Reporter)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/76967a6cba2231a9954e9725ae5f0844912eaf38
Bug 1256236 - Remove unused Distribution.getDescriptor(). r=sebastian

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/76967a6cba22
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
(Assignee)

Comment 6

2 years ago
hey  Sebastian Kaspari (:sebastian) 

Can you help in vouch my mozillian profile. I have contributed with two bugs.

here the link : https://mozillians.org/en-US/u/write2umeshkumhar/
(Assignee)

Comment 7

2 years ago
hey  Sebastian Kaspari (:sebastian) 

Can you help in vouch my mozillian profile. I have contributed with two bugs.

here the link : https://mozillians.org/en-US/u/write2umeshkumhar/

Thank you
You need to log in before you can comment on or make changes to this bug.