Reduce logging in DynamicToolbarAnimator

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

unspecified
Firefox 48
All
Android
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Scrolling on a website spams the log with messages like this:

> 03-14 09:46:18.961 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -7.2089844
> 03-14 09:46:18.978 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -6.689087
> 03-14 09:46:18.995 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -7.5994873
> 03-14 09:46:19.011 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -5.362549
> 03-14 09:46:19.028 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -4.364868
> 03-14 09:46:19.045 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -4.9331055
> 03-14 09:46:19.063 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -4.904297
> 03-14 09:46:19.078 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -4.8218994
> 03-14 09:46:19.095 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -5.6450195
> 03-14 09:46:19.112 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -5.1488037
> 03-14 09:46:19.128 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -6.8483887
> 03-14 09:46:19.145 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -5.5306396

Assuming that excessive logging affects performance and that those debug messages are not needed anymore, I'd like to get rid of those. This is in all versions up to the release version.
(Assignee)

Comment 1

2 years ago
@snorp: I guess you know whether these log messages are needed for debugging?
Flags: needinfo?(snorp)
(Assignee)

Comment 2

2 years ago
Created attachment 8730169 [details]
MozReview Request: Bug 1256237 - DynamicToolbarAnimator: Reduce verbose logging. r?

Review commit: https://reviewboard.mozilla.org/r/39733/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39733/
Comment on attachment 8730169 [details]
MozReview Request: Bug 1256237 - DynamicToolbarAnimator: Reduce verbose logging. r?

https://reviewboard.mozilla.org/r/39733/#review36577
Attachment #8730169 - Flags: review+
We can probably remove that. I r+ed.
Flags: needinfo?(snorp)
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/3d2235db2ebe87a767f9e30ab33cc456273075ce
Bug 1256237 - DynamicToolbarAnimator: Reduce verbose logging. r=snorp

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3d2235db2ebe
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.