1256237 - Reduce logging in DynamicToolbarAnimator

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Scrolling on a website spams the log with messages like this:

> 03-14 09:46:18.961 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -7.2089844
> 03-14 09:46:18.978 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -6.689087
> 03-14 09:46:18.995 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -7.5994873
> 03-14 09:46:19.011 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -5.362549
> 03-14 09:46:19.028 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -4.364868
> 03-14 09:46:19.045 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -4.9331055
> 03-14 09:46:19.063 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -4.904297
> 03-14 09:46:19.078 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -4.8218994
> 03-14 09:46:19.095 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -5.6450195
> 03-14 09:46:19.112 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -5.1488037
> 03-14 09:46:19.128 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -6.8483887
> 03-14 09:46:19.145 25017 25017 V GeckoDynamicToolbarAnimator: Got vertical translation -5.5306396

Assuming that excessive logging affects performance and that those debug messages are not needed anymore, I'd like to get rid of those. This is in all versions up to the release version.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

@snorp: I guess you know whether these log messages are needed for debugging?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1256237 - DynamicToolbarAnimator: Reduce verbose logging. r?

Review commit: https://reviewboard.mozilla.org/r/39733/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39733/

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8730169 [details]
MozReview Request: Bug 1256237 - DynamicToolbarAnimator: Reduce verbose logging. r?

https://reviewboard.mozilla.org/r/39733/#review36577

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

We can probably remove that. I r+ed.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/3d2235db2ebe87a767f9e30ab33cc456273075ce
Bug 1256237 - DynamicToolbarAnimator: Reduce verbose logging. r=snorp

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3d2235db2ebe