1256247 - Tapping back after going to "I ran into some problems" on input.mozilla.org won't dismiss the snippet from the bottom of the page

Status: RESOLVED FIXED

(Input :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Go to https://input.mozilla.org/en-US/feedback/android/48.0a1/nightly/?utm_source=feedback-prompt
2. Tap "I ran into some problems"
3. Tap back

Expected results:
- After tapping "I ran into some problems", a snippet is displayed at the bottom "Visit out Support Site to get answers for common issues"
- Tapping back, will dismiss it

Actual results:
- Tapping back, the snippet is not dismissed

Note:
- Tapping "Maybe later" and "No Thanks" does nothing
- on about:feedback, the snippet is dismissed

Comment 1

[:Margaret Leibovic]

Is there a more appropriate Bugzilla component for this? It's not part of the Firefox for Android code base.

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

:margaret, this appears to be two bugs, and one of them may be in the Fennec codebase. 

1) The support snippet is not dismissed on back button press. This is an Input bug (moved it appropriately).
2) Maybe Later/No Thanks do nothing. I don't know what is going on; it probably depends on the version the tester was using in comment 0. :TeoVermesan, what version were you using?

Comment 3

[Teodora Vermesan (:TeoVermesan)]

It was the 13-03 build. 
The first time when input.mozilla.org is invoked, "Maybe later"/"No Thanks" work ok and about:home is displayed.
Going to history and open Firefox Feedback, tapping "Maybe later"/"No Thanks" does nothing.

Comment 4

[:Margaret Leibovic]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #3)
> It was the 13-03 build. 
> The first time when input.mozilla.org is invoked, "Maybe later"/"No Thanks"
> work ok and about:home is displayed.
> Going to history and open Firefox Feedback, tapping "Maybe later"/"No
> Thanks" does nothing.

The "Maybe later"/"No Thanks" links will only work if Firefox automatically opened the page, not if you went to it directly. We are only attaching the required listeners in the case where we open it ourselves.

It looks like the problem here is that accessing the page from history will give input the URL parameters that make it seem like Firefox opened it itself, so input doesn't know to hide these links. I'm not sure what there is for us to do in this case.

Comment 5

[Teodora Vermesan (:TeoVermesan)]

Also "Maybe later"/"No Thanks" don't work after the following scenario:
- invoke Firefox Feedback
- tap "I ran into some problems"
- go back
- tap "I love it"
- then go back
- tap "Maybe later"/"No Thanks"
=> no action

Comment 6

[Osmose [:osmose, :mkelly]]

(In reply to :Margaret Leibovic from comment #4)
> It looks like the problem here is that accessing the page from history will
> give input the URL parameters that make it seem like Firefox opened it
> itself, so input doesn't know to hide these links. I'm not sure what there
> is for us to do in this case.

Would it be possible to detect those listeners in a way that doesn't depend on the URL parameters?

Alternatively, I'm okay with just calling this expected yet unfortunate behavior if you are.

Comment 7

[Justin Crawford [:hoosteeno] [:jcrawford]]

:margaret, I think Osmose is on to something. The parameter may be too simple a solution for this -- it creates all sorts of unexpected bugs like the ones above. But near as I can tell, there is not a good way to test whether a particular event has any listeners.

Is there any way we could create some unique artifact in the DOM when...
a) the page is loaded by the Feedback Prompt 
b) the page is loaded by the Feedback Link

Then we could test for that.

Comment 8

[:Margaret Leibovic]

(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #7)
> :margaret, I think Osmose is on to something. The parameter may be too
> simple a solution for this -- it creates all sorts of unexpected bugs like
> the ones above. But near as I can tell, there is not a good way to test
> whether a particular event has any listeners.
> 
> Is there any way we could create some unique artifact in the DOM when...
> a) the page is loaded by the Feedback Prompt 
> b) the page is loaded by the Feedback Link
> 
> Then we could test for that.

What kind of artifact do you have in mind? As the browser, we can do anything to the DOM of any page that's loaded, I'm just worried about this being fragile and hacky.

How about firing an event? Similar to "DOMContentLoaded", the browser could fire something like "FeedbackPrompted" for the case where we load the link from the prompt. The page could listen for the event and in that case show the "Maybe later"/"No thanks" links.

The case where we load from the link should be the same as what happens if the user navigates to the page themselves organically, so I don't think we need to do anything special in that case.

Comment 9

[Osmose [:osmose, :mkelly]]

I think an event would be fine. The links will still work as long as the user doesn't leave the page, right? If the user goes to the second step of feedback and then back, and we've fixed the footer issue so that the footer with the "Maybe later"/"No thanks" links shows when they go back, will the links still function?

hoosteeno: Are you going to be handling these bugs? I can be on hand to review, merge, and deploy the fixes if you are.

Comment 10

[Justin Crawford [:hoosteeno] [:jcrawford]]

 
> How about firing an event? Similar to "DOMContentLoaded", the browser could
> fire something like "FeedbackPrompted" for the case where we load the link
> from the prompt. The page could listen for the event and in that case show
> the "Maybe later"/"No thanks" links.

This works for me. If you can get me a version of nightly that has this feature, I can sideload it and start working on this and other bugs blocking bug 1253423.

Comment 11

[:Margaret Leibovic]

I filed bug 1259186 for the client changes here.

Comment 12

[Justin Crawford [:hoosteeno] [:jcrawford]]

PR here: https://github.com/mozilla/fjord/pull/737

Comment 13

[Justin Crawford [:hoosteeno] [:jcrawford]]

This has landed in staging and in prod.