1256251 - Update browser.cookies.onChanged to match Chrome's behaviour when overwriting a cookie

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Bob Silverberg [:bsilverberg]]

As per the docs [1]:

`As a special case, note that updating a cookie's properties is implemented as a two step process: the cookie to be updated is first removed entirely, generating a notification with "cause" of "overwrite" . Afterwards, a new cookie is written with the updated values, generating a second notification with "cause" "explicit".`

However, we do not currently do this with the API. We fire an event with removed: "false" and cause: "overwrite", which does not match the above behaviour. This bug to to change that so that when we receive notification that a cookie has been updated we fire both of the above-mentioned events, rather than the single event that we currently fire.

Kris/Andy, do you agree that we should make this change?

[1] https://developer.chrome.com/extensions/cookies#event-onChanged

Comment 1

[Andy McKay]

As long as we don't inherit a huge technical debt (its a few lines of code) then lets copy Chrome.

Comment 2

[Bob Silverberg [:bsilverberg]]

Attachment: MozReview Request: Bug 1256251 - Update browser.cookies.onChanged to match Chrome's behaviour when overwriting a cookie, r?kmag

Review commit: https://reviewboard.mozilla.org/r/39701/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39701/

Comment 3

[Bob Silverberg [:bsilverberg]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=025dd0989978

Comment 4

[Bob Silverberg [:bsilverberg]]

Note that I did check Chrome and confirmed that the documented behaviour matches the actual behaviour.

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8730147 [details]
MozReview Request: Bug 1256251 - Update browser.cookies.onChanged to match Chrome's behaviour when overwriting a cookie, r?kmag

https://reviewboard.mozilla.org/r/39701/#review36351

Hm. This is a strange API...

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c492b319e0c0

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c492b319e0c0