1256257 - Crashes with "Attempting to connect to non-local address" when running mochitest

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[James Kitchener (:jkitch)]

The Windows 10 welcome page is still showing in reftests.  Bug 1248316 fixed it for mochitests, but I still reproduce it when running reftests.

Command used:  mach reftest layout/reftests/mathml

The changeset from bug 1248316 blanks out the welcome URL, but is their something preventing reftest from applying the testing/profiles/prefs_general.js preference overrides?

https://dxr.mozilla.org/mozilla-central/source/testing/profiles/prefs_general.js#346

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1256257 - Clear Win10 intro page url for reftest.

Review commit: https://reviewboard.mozilla.org/r/40347/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40347/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8731075 [details]
MozReview Request: Bug 1256257 - Clear Win10 intro page url for reftest.

https://reviewboard.mozilla.org/r/40347/#review36913

worth landing now, but do consider the other harnesses.

::: layout/tools/reftest/reftest-preferences.js:111
(Diff revision 1)
>  user_pref("browser.tabs.remote.autostart.1", false);
>  user_pref("browser.tabs.remote.autostart.2", false);
>  
>  user_pref("startup.homepage_welcome_url", "");
>  user_pref("startup.homepage_override_url", "");
> +user_pref("browser.usedOnWindows10.introURL", "");

will we need this preference for mochitest and talos?

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

I already did this for mochitest in bug 1248316. Not sure about talos...

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0fed34549aa

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

please fix this for talos:
https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/config.py#61

either in this bug or in another bug.  We should make sure this is clearly stating that this is a windows10 issue, not a general issue.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c0fed34549aa

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

(In reply to Joel Maher (:jmaher) (PTO- Back April 4th) from comment #5)
> please fix this for talos:
> https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/config.
> py#61
> 
> either in this bug or in another bug.  We should make sure this is clearly
> stating that this is a windows10 issue, not a general issue.

This is not an issue at all for now, because talos explicitly refuse to run on Windows 10 :)

https://dxr.mozilla.org/mozilla-central/rev/55d557f4d73ee58664bdf2fa85aaab555224722e/testing/talos/talos/utils.py#29-37

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

actually we do run talos on windows 10, it is reported as win8, can you please address comment 16.

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Comment 16? What will that be? I cannot address a comment which doesn't exist yet :)

Well, I tried to run talos on my windows 10 machine, and it fails with exception at the place I mentioned in comment 7: https://hg.mozilla.org/mozilla-central/file/2dc0cb4fdad6675597e93f6634ee6c48a2f42a1f/testing/talos/talos/utils.py#l37

If I cannot run it locally, I'm not able to confirm it is a valid issue, and also I cannot check whether a patch really fixes the issue...

I've left a comment in bug 1185879 which seems to be the bug for running talos on windows 10.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

oh, I meant comment 5- good catch :)

Most likely the windows 10 we have setup for automation (still working on getting tests green there, as well as configs, and machines available) is not the same as what you have locally- maybe it was a pre-release version or something else.

Thanks for clarifying your comment!