1256268 - Resource leaks in fipstest.c

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Franziskus Kiefer [:franziskus]]

The file fipstest.c contains multiple resource leaks in function drbg, i.e. the loser label does not free any variables.

* predictedreturn_bytes (CID 1355468)
* additionalInput (CID 983285)
* personalizationString (CID 983284)
* nonce (CID 983283)
* entropyInput (CID 983282)
* predictedreturn_bytes (CID 1355468)
* return_bytes (CID 1355467)

Comment 1

[Franziskus Kiefer [:franziskus]]

adding CID 1355469 in pk1sign.c (data in SignFile is not freed)

Comment 2

[Franziskus Kiefer [:franziskus]]

Attachment: fixing-resource-leaks.patch

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8732840 [details] [diff] [review]
fixing-resource-leaks.patch

Review of attachment 8732840 [details] [diff] [review]:
-----------------------------------------------------------------

::: cmd/pk1sign/pk1sign.c
@@ +162,5 @@
>      ExportPublicKey(outFile, cert);
>      
>      SECKEY_DestroyPrivateKey(privKey);
>      PORT_FreeArena(arena, PR_FALSE);
> +    PORT_Free(data);

There are a few "return -1" lines in this function where we return early upon error. Looks like we'd leak the arena and the private key then, maybe we should come back later and rewrite this in C-style using the "goto loser" pattern.

Comment 4

[Franziskus Kiefer [:franziskus]]

Attachment: pk1sign-fixup.patch

follow up to make SignFile free all the things on return.

Comment 5

[Franziskus Kiefer [:franziskus]]

https://hg.mozilla.org/projects/nss/rev/3e097ed7969a
https://hg.mozilla.org/projects/nss/rev/e859db13b9da