Land version 1.1.12 of the Loop system add-on in mozilla-central

RESOLVED FIXED in Firefox 46

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed, firefox48 fixed)

Details

(Whiteboard: [btpp-fix-now])

Attachments

(2 attachments)

This is a minor update to the 1.1.11 version landed in bug 1253731.

Since the last version that landed in mozilla-central we have:

- Fixed an issue with the first-time user display (added in previous 1.1 versions), where the panel would frequently be the wrong height, caused by a bad interaction between css & resizing.

- Importing latest update from localisations.
https://hg.mozilla.org/integration/fx-team/rev/5be369e4bcbfc25c10e02d1922beb98072e000cd
Bug 1256287 - Land version 1.1.12 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.

https://hg.mozilla.org/integration/fx-team/rev/9f83644040b586b884320b1a9f5fc8c11b6d7b68
Bug 1256287 - Land version 1.1.12 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code.
Comment on attachment 8730175 [details] [diff] [review]
Land version 1.1.12 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.1 version
[User impact if declined]: Some locales may be out of date
[Describe test coverage new/current, TreeHerder]: N/A
[Risks and why]: Low - just imports the latest localisations into Hello.
[String/UUID change made/needed]: None
Attachment #8730175 - Flags: approval-mozilla-aurora?
Note: here's the changelog:

https://github.com/mozilla/loop/blob/release/CHANGELOG.md

(the two other bugs not mentioned in comment 0, are landing separately).
Attachment #8730175 - Flags: approval-mozilla-beta?
Comment on attachment 8730176 [details] [diff] [review]
Land version 1.1.12 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.1
[User impact if declined]: The first time user display in the Loop panel may be displayed with the panel at the wrong height, covering up some of the display making it inaccessible. This is a new display in the 1.1 version.
[Describe test coverage new/current, TreeHerder]: Landed in fx-team. css-only change, plenty of manual testing on the bug when we found it.
[Risks and why]: Low, minor css change and bump of version number.
[String/UUID change made/needed]: None
Attachment #8730176 - Flags: approval-mozilla-beta?
Attachment #8730176 - Flags: approval-mozilla-aurora?
Comment on attachment 8730175 [details] [diff] [review]
Land version 1.1.12 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.

CSS regression fix to make the UI usable again. Please uplift to aurora and beta.
Attachment #8730175 - Flags: approval-mozilla-beta?
Attachment #8730175 - Flags: approval-mozilla-beta+
Attachment #8730175 - Flags: approval-mozilla-aurora?
Attachment #8730175 - Flags: approval-mozilla-aurora+
Attachment #8730176 - Flags: approval-mozilla-beta?
Attachment #8730176 - Flags: approval-mozilla-beta+
Attachment #8730176 - Flags: approval-mozilla-aurora?
Attachment #8730176 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/5be369e4bcbf
https://hg.mozilla.org/mozilla-central/rev/9f83644040b5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.