Closed Bug 1256302 Opened 5 years ago Closed 4 years ago
Verifier::Init Cert Verifier Log()
58 bytes, text/x-review-board-request
The function is empty ever since the changes in Bug 1219482.
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [psm-cleanup] → [psm-assigned]
Comment on attachment 8787090 [details] Bug 1256302 - Remove CertVerifier::InitCertVerifierLog(). https://reviewboard.mozilla.org/r/75954/#review74280 Agreed. Thanks, Cykesiopka!
Attachment #8787090 - Flags: review?(jjones) → review+
Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e13cf9ee0b2 (The orange is an intermittent.)
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f615741c86ee Remove CertVerifier::InitCertVerifierLog(). r=jcj
Landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/f615741c86eed245173be02078053f4801403ba4. Cykesiopka, jcj, mozreview said that no suitable reviewer granted 'Ship it'. Is jcj missing from a reviewer list which mozreview uses?
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] from comment #5) > Landed as > https://hg.mozilla.org/integration/mozilla-inbound/rev/ > f615741c86eed245173be02078053f4801403ba4. Thanks. > Cykesiopka, jcj, mozreview said that no suitable reviewer granted 'Ship it'. > Is jcj missing from a reviewer list which mozreview uses? I'm not sure why MozReview says that, or what criteria it uses to judge. I guess I'll ask around later. Anyways, jcj is more than qualified to review a change like this.
(In reply to :Cykesiopka from comment #6) > I'm not sure why MozReview says that, or what criteria it uses to judge. I > guess I'll ask around later. I asked on #mozreview, and the answer is probably that neither of us have L3 commit access. See e.g. the logic here: https://hg.mozilla.org/hgcustom/version-control-tools/file/76361888285e9db8f8096b1e5d6eb1a3ff2baf42/pylib/mozreview/mozreview/hooks.py#l108 (I probably should try and get L3 access at this point...)
You need to log in before you can comment on or make changes to this bug.