Remove CertVerifier::InitCertVerifierLog()

RESOLVED FIXED in Firefox 51

Status

()

defect
P1
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [psm-assigned], )

Attachments

(1 attachment)

Assignee

Description

3 years ago
The function is empty ever since the changes in Bug 1219482.
Assignee

Updated

3 years ago
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [psm-cleanup] → [psm-assigned]
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8787090 [details]
Bug 1256302 - Remove CertVerifier::InitCertVerifierLog().

https://reviewboard.mozilla.org/r/75954/#review74280

Agreed. Thanks, Cykesiopka!
Attachment #8787090 - Flags: review?(jjones) → review+
Assignee

Comment 3

3 years ago
Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e13cf9ee0b2
(The orange is an intermittent.)
Keywords: checkin-needed

Comment 4

3 years ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f615741c86ee
Remove CertVerifier::InitCertVerifierLog(). r=jcj
Keywords: checkin-needed
Landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/f615741c86eed245173be02078053f4801403ba4.

Cykesiopka, jcj, mozreview said that no suitable reviewer granted 'Ship it'. Is jcj missing from a reviewer list which mozreview uses?
Assignee

Comment 6

3 years ago
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] from comment #5)
> Landed as
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> f615741c86eed245173be02078053f4801403ba4.

Thanks.

> Cykesiopka, jcj, mozreview said that no suitable reviewer granted 'Ship it'.
> Is jcj missing from a reviewer list which mozreview uses?

I'm not sure why MozReview says that, or what criteria it uses to judge. I guess I'll ask around later.
Anyways, jcj is more than qualified to review a change like this.

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f615741c86ee
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee

Comment 8

3 years ago
(In reply to :Cykesiopka from comment #6)
> I'm not sure why MozReview says that, or what criteria it uses to judge. I
> guess I'll ask around later.

I asked on #mozreview, and the answer is probably that neither of us have L3 commit access.
See e.g. the logic here: https://hg.mozilla.org/hgcustom/version-control-tools/file/76361888285e9db8f8096b1e5d6eb1a3ff2baf42/pylib/mozreview/mozreview/hooks.py#l108
(I probably should try and get L3 access at this point...)
You need to log in before you can comment on or make changes to this bug.