Closed
Bug 1256314
Opened 8 years ago
Closed 8 years ago
Toolbar of Responsive Design Mode twitches by 2-3px on startup
Categories
(DevTools :: Responsive Design Mode, defect, P2)
DevTools
Responsive Design Mode
Tracking
(firefox47 wontfix, firefox48 verified, firefox49 verified, firefox50 verified)
VERIFIED
FIXED
Firefox 50
People
(Reporter: arni2033, Assigned: ntim)
References
()
Details
(Keywords: regression, Whiteboard: [btpp-fix-later])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
jryans
:
review+
gchang
:
approval-mozilla-aurora+
gchang
:
approval-mozilla-beta+
|
Details |
>>> My Info: Win7_64, Nightly 48, 32bit, ID 20160313030418 STR: 1. Open http://www.rp-online.de/ 2. Press Ctrl+Shift+M 3. Wait 5-10 seconds AR: All buttons on Responsive design mode twitch when user agent field appears ER: No twitching This is regression from bug 828008. Regression range: > https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=978a7d2a4475f3368367c48c83557d4c41a23695&tochange=ed627972a4806a23c79dae4a08f53c795becb8fb
Screencast:
> https://dl.dropboxusercontent.com/s/mpvklb4a661lihx/bug%201256314%20comment%201.webm?dl=0
Looks like the user agent field causes the toolbar to grow a few pixels in height. Perhaps :ntim will be interested in taking a look.
Priority: -- → P2
Whiteboard: [btpp-fix-later]
Tim this is a new regression in 48, can you take a look?
Assignee: nobody → ntim.bugs
Flags: needinfo?(ntim.bugs)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(ntim.bugs)
(:ntim left the assignee field set but did not reply, so I am not sure if he is looking at this...) Jaideep, maybe you could take a look at this? I think adjusting the toolbar CSS to account for the extra height should do it. This is in the "old" RDM (the one currently shipped to users).
Flags: needinfo?(jaideepb)
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/60092/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/60092/
Attachment #8764053 -
Flags: review?(jryans)
Looks like :ntim is working on this one after all.
Flags: needinfo?(jaideepb)
Comment on attachment 8764053 [details] Bug 1256314 - Fix twitching of RDM toolbar on startup. https://reviewboard.mozilla.org/r/60092/#review56984 Thanks, that appears to work! Please request uplift through to beta (48) once it lands.
Attachment #8764053 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 8•8 years ago
|
||
Landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/2c11e355dbf5
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2c11e355dbf5
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•8 years ago
|
Comment on attachment 8764053 [details] Bug 1256314 - Fix twitching of RDM toolbar on startup. Approval Request Comment [Feature/regressing bug #]: Regression from bug 828008 [User impact if declined]: Responsive Design UI in DevTools will twitch on open as elements pop into place. [Describe test coverage new/current, TreeHerder]: On m-c, manual testing. [Risks and why]: Low, CSS only change. [String/UUID change made/needed]: None
Attachment #8764053 -
Flags: approval-mozilla-beta?
Attachment #8764053 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•8 years ago
|
status-firefox47:
--- → wontfix
Comment 11•8 years ago
|
||
Comment on attachment 8764053 [details] Bug 1256314 - Fix twitching of RDM toolbar on startup. This patch fixes the regression. Take it in 48 beta 4 and aurora.
Attachment #8764053 -
Flags: approval-mozilla-beta?
Attachment #8764053 -
Flags: approval-mozilla-beta+
Attachment #8764053 -
Flags: approval-mozilla-aurora?
Attachment #8764053 -
Flags: approval-mozilla-aurora+
Updated•8 years ago
|
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/59f710308c26
Comment 13•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/59f710308c26
Comment 14•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/49ba9e8f7067
Updated•8 years ago
|
Flags: qe-verify+
Comment 15•8 years ago
|
||
Hello, I have reproduced this issue using the STR from the description on Win7 x64 using Nightly 48 32bit (20160313030418). I have tested the issue on Win7 x64 using Fx Beta 48.0b4, Fx DevEdition 49.0a2 and Fx Nightly 50.0a1 and it is VERIFIED FIXED. Setting the flags accordingly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•