Closed Bug 1256314 Opened 8 years ago Closed 8 years ago

Toolbar of Responsive Design Mode twitches by 2-3px on startup

Categories

(DevTools :: Responsive Design Mode, defect, P2)

defect

Tracking

(firefox47 wontfix, firefox48 verified, firefox49 verified, firefox50 verified)

VERIFIED FIXED
Firefox 50
Tracking Status
firefox47 --- wontfix
firefox48 --- verified
firefox49 --- verified
firefox50 --- verified

People

(Reporter: arni2033, Assigned: ntim)

References

()

Details

(Keywords: regression, Whiteboard: [btpp-fix-later])

Attachments

(1 file)

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160313030418
STR:
1. Open http://www.rp-online.de/
2. Press Ctrl+Shift+M
3. Wait 5-10 seconds

AR:  All buttons on Responsive design mode twitch when user agent field appears
ER:  No twitching

This is regression from bug 828008. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=978a7d2a4475f3368367c48c83557d4c41a23695&tochange=ed627972a4806a23c79dae4a08f53c795becb8fb
Looks like the user agent field causes the toolbar to grow a few pixels in height.

Perhaps :ntim will be interested in taking a look.
Priority: -- → P2
Whiteboard: [btpp-fix-later]
Tim this is a new regression in 48, can you take a look?
Assignee: nobody → ntim.bugs
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(ntim.bugs)
(:ntim left the assignee field set but did not reply, so I am not sure if he is looking at this...)

Jaideep, maybe you could take a look at this?  I think adjusting the toolbar CSS to account for the extra height should do it.

This is in the "old" RDM (the one currently shipped to users).
Flags: needinfo?(jaideepb)
Looks like :ntim is working on this one after all.
Flags: needinfo?(jaideepb)
Comment on attachment 8764053 [details]
Bug 1256314 - Fix twitching of RDM toolbar on startup.

https://reviewboard.mozilla.org/r/60092/#review56984

Thanks, that appears to work!

Please request uplift through to beta (48) once it lands.
Attachment #8764053 - Flags: review?(jryans) → review+
https://hg.mozilla.org/mozilla-central/rev/2c11e355dbf5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment on attachment 8764053 [details]
Bug 1256314 - Fix twitching of RDM toolbar on startup.

Approval Request Comment
[Feature/regressing bug #]: Regression from bug 828008
[User impact if declined]: Responsive Design UI in DevTools will twitch on open as elements pop into place.
[Describe test coverage new/current, TreeHerder]: On m-c, manual testing.
[Risks and why]: Low, CSS only change.
[String/UUID change made/needed]: None
Attachment #8764053 - Flags: approval-mozilla-beta?
Attachment #8764053 - Flags: approval-mozilla-aurora?
Comment on attachment 8764053 [details]
Bug 1256314 - Fix twitching of RDM toolbar on startup.

This patch fixes the regression. Take it in 48 beta 4 and aurora.
Attachment #8764053 - Flags: approval-mozilla-beta?
Attachment #8764053 - Flags: approval-mozilla-beta+
Attachment #8764053 - Flags: approval-mozilla-aurora?
Attachment #8764053 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
Hello,
I have reproduced this issue using the STR from the description on Win7 x64 using Nightly 48 32bit (20160313030418). 
I have tested the issue on Win7 x64 using Fx Beta 48.0b4, Fx DevEdition 49.0a2 and Fx Nightly 50.0a1 and it is VERIFIED FIXED. 
Setting the flags accordingly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: