1256315 - Holding/quickly pressing Ctrl+Shift+M breaks Responsive Design Mode

Status: RESOLVED WORKSFORME

(DevTools :: Responsive Design Mode, defect, P2)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160313030418
STR_A:
1. Open the following "data:" url or click URL in the form above
>   data:text/html,<input value="hello"><textarea>world
2. Hold Ctrl+Shift+M for 5 seconds
3. Wait 5-10 seconds
4. Press Ctrl+M once

STR_B:
1. Open http://www.rp-online.de/
2. Hold Ctrl+Shift+M for 5 seconds  OR  Quickly press Ctrl+Shift+M 4-8 times
3. Wait 5-10 seconds
4. Press Ctrl+M once

AR:  No visible action after Step 4. Responsive design has broken for the tab.
ER:  Responsive design should be toggled after Step 4.

Some sites may have Ctrl+Shift+M hotkey, so if user will try to use it on a site/page that doesn't have Ctrl+Shift+M hotkey, user may probably stuck in responsive design mode

This is regression from bug 828008. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=978a7d2a4475f3368367c48c83557d4c41a23695&tochange=ed627972a4806a23c79dae4a08f53c795becb8fb

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Not sure how likely this case is, but it would be good to fix if we can.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Tim, can you take a look?

Comment 3

[arni2033]

Correction:
From what I saw, it's impossible to stuck in responsive design mode like this. It's only possible to stuck in normal mode, which is OK for end user anyway.
Also, I remember that I encountered this bug after 2 (two) pressings of Ctrl+Shift+M on sites:
(1) https://hi-tech.mail.ru/news/phone-music-covers/   (2) http://www.rp-online.de/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

A fix for this would be nice to have, but I am okay shipping 48 without it as well.

Assuming that :ntim is not interested since there was no reply.

Comment 5

[Tim Nguyen :ntim]

not happening with new RDM