1256335 - Correct entry for max-height in mdn/data css/properties.json to use "regardingHeightOfGeneratedBoxContainingBlockPercentagesRelativeToContainingBlock"

Status: RESOLVED WONTFIX

(Developer Documentation Graveyard :: CSS, defect, P5)

Description

[Stephen Perelson]

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: unspecified
 Technical Contact: 

:: Details

This is just to correct an ambiguous use of the word "none". The description for the "percentage" value of the max-height CSS setting claims:

> The <percentage> is calculated with respect to the height of the containing block. If the height of the containing block is not specified explicitly, the percentage value is treated as none.

This is not technically correct as this could be misconstrued to be that the max-height would be set to "none" when in fact the percentage is set to zero. This should preferably be:

> The <percentage> is calculated with respect to the height of the containing block. If the height of the containing block is not specified explicitly, the percentage value is treated as zero.

Comment 1

[kshitija]

I would like to work on this bug. Can you help me?

Comment 2

[kshitija]

Made the necessary change. Please review
https://developer.mozilla.org/en-US/docs/Web/CSS/max-height

Comment 3

[Stephen Perelson]

Thank you. It is great to see a suggested edit make it into the docs.

I noticed that the "Properties" table in the Summary also includes a description of "Percentages" that refers to "none". Please would you change it from:

", the percentage value is treated as none."

to

", the percentage value is treated as zero."

Since my suggested edit only affects the behaviour of explicitly defined percentages, that should be the only other change.

Thank you again for taking the time.

Comment 4

[Janet Swisher]

Technically, neither "none" nor "zero" is correct; the max-height percentage is resolved against the height of the containing block, howsoever that may be determined by the relevant layout module (see https://drafts.csswg.org/css-sizing-3/#valdef-width-length-percentage). I've updated the wiki-based content of the article and changed the title of the bug to indicate what needs to be done to fix the info box. Once that change is pushed, need to force-refresh the page.

Comment 5

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.