1256355 - Bug 1253203 seems to have broken builds on Mac OS X with homebrew's autoconf213.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Blake Winton (:bwinton) (:☕️)]

I specify:
  mk_add_options AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213
in my .mozconfig, and get the error:
  js/src> Could not find autoconf 2.13

There's also a typo on https://hg.mozilla.org/mozilla-central/rev/e654e71b61b5#l4.53
  if find:
should be
  if fink:

Patch incoming.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Attachment: A typo fix and homebrew support.

This fixes it for me, fwiw…

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8730259 [details] [diff] [review]
A typo fix and homebrew support.

Review of attachment 8730259 [details] [diff] [review]:
-----------------------------------------------------------------

Bonus points if you throw in a "if not os.path.exists(autoconf): error(...)" check to verify the fink and brew code actually finds a file. Currently, we're assuming the file exists.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Attachment: MozReview Request: Bug 1256355 - Look for homebrew's autoconf213, and fix a typo. r=gps.

Review commit: https://reviewboard.mozilla.org/r/39801/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39801/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8730326 [details]
MozReview Request: Bug 1256355 - Look for homebrew's autoconf213, and fix a typo.  r=gps.

https://reviewboard.mozilla.org/r/39801/#review36413

Thanks for following up!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77d0e430eaab

Comment 6

[Mike Hommey [:glandium]]

That still leaves why setting AUTOCONF in your mozconfig failed in the first place.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

I'm not sure, but from the error message, it looked like the mozconfig wasn't being passed in to the autoconf function when it was called from the js/src directory.  (By which I mean when I tried to print it, it was null, iirc. ;)

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/77d0e430eaab