Closed
Bug 1256357
Opened 8 years ago
Closed 8 years ago
Enable Hello in e10s windows
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(e10s+, firefox46 wontfix, firefox47 fixed, firefox48 verified)
People
(Reporter: mikedeboer, Assigned: mikedeboer)
References
Details
(Whiteboard: [e10s])
Attachments
(2 files)
This is basically only setting `loop.remote.autostart` to `true`. The idea is to have this enabled on Nightly only for now.
Flags: qe-verify+
Flags: firefox-backlog+
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8730698 -
Flags: review?(standard8)
Updated•8 years ago
|
Comment 2•8 years ago
|
||
Comment on attachment 8730698 [details] [diff] [review] Patch v1: flip le pref. I'm happy with this, as long as we land it after bug 1254102 and bug 1245813 have landed. Alternately, if bug 1245813 isn't fully fixed by tomorrow, then I suggest we look at getting bug 1255491 into central with the pref flipped, and then landing this.
Attachment #8730698 -
Flags: review?(standard8) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4f746ff87cefd9cefd2d827868a278559a3a0655 Bug 1256357: Enable Hello in e10s windows by default. r=Standard8
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4f746ff87cef
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 6•8 years ago
|
||
The PR has also landed: https://github.com/mozilla/loop/commit/5a8569a0cb865b34f5b3fef8d83a5771fc41003d
Updated•8 years ago
|
QA Contact: bogdan.maris
Comment 7•8 years ago
|
||
I see that the pref is flipped to 'true' in Nightly 48.0a1, but also in Developer Edition 47.0a2. Is this intended?
Status: RESOLVED → VERIFIED
Flags: qe-verify+ → needinfo?(standard8)
Comment 8•8 years ago
|
||
Yes, e10s is being enabled generally for more users in the beta 47 cycle, so we want to get it enabled in the add-on for extra testing. The pref change here just flipped the default for the add-on. Note also bug 1258834 which disables it for FF 46 since that doesn't have enough support for it to be turned on.
Flags: needinfo?(standard8)
Comment 9•8 years ago
|
||
Mark, does the mozilla-central change (comment 5) need to be uplifted to Aurora 47 to match the Hello add-on pref?
Comment 10•8 years ago
|
||
(In reply to Chris Peterson [:cpeterson] from comment #9) > Mark, does the mozilla-central change (comment 5) need to be uplifted to > Aurora 47 to match the Hello add-on pref? Nope, this was landed with bug 1258865 - the 1.2.2 update of the system add-on. Note: we're working on improving our tracking systems for when we land the system add-on, so hopefully this will be clearer in future.
You need to log in
before you can comment on or make changes to this bug.
Description
•