1256364 - Make SimpleTest's window.onerror actually report the stack for the exception

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Boris Zbarsky [:bzbarsky]]

What bug 511888 should have been, but I'm not sure we had the core bits in place then.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: If we have an exception stack in the onerror handler in SimpleTest, include it in the error message

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8730272 [details] [diff] [review]
If we have an exception stack in the onerror handler in SimpleTest, include it in the error message

Review of attachment 8730272 [details] [diff] [review]:
-----------------------------------------------------------------

these changes are just fine, but I am not sure how the onerror handler will get column and exception parameters.  Please explain that and I will be fine with a r+.

::: testing/mochitest/tests/SimpleTest/SimpleTest.js
@@ +1527,5 @@
>  var info = SimpleTest.info;
>  
>  var gOldOnError = window.onerror;
> +window.onerror = function simpletestOnerror(errorMsg, url, lineNumber,
> +                                            columnNumber, originalException) {

will we have columnNumber and originalException?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> but I am not sure how the onerror handler will get column and exception parameters.  

They're always passed to the onerror handler.  See https://html.spec.whatwg.org/multipage/webappapis.html#the-event-handler-processing-algorithm step 3, which will be reached from https://html.spec.whatwg.org/multipage/webappapis.html#report-the-error step 13.  Steps 11 and 12 of this last algorithm are what set up the state on the ErrorEvent for the first algorithm to grab from there.

Alternately, see https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onerror or I can link you to the relevant part of our source.  ;)

Or did you want the explanation in a comment SimpleTest.js?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8730272 [details] [diff] [review]
If we have an exception stack in the onerror handler in SimpleTest, include it in the error message

thanks for explaining that :bz.  I think having this discoverable from a commit message -> bug comments is enough if we have questions in the future.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dca912a377ea

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dca912a377ea