Closed Bug 1256373 Opened 4 years ago Closed 4 years ago

10% Painted Layer Region building in IE mazesolver

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: BenWa, Assigned: BenWa)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

This gets worse the longer the test is running (more complicated the page is). It doesn't show up much if you only profile the first 3 seconds of the test.
Comment on attachment 8730417 [details]
MozReview Request: Bug 1256373 - Simplify mMaybeHitRegion. r?tn

I don't know if it's safe to simplify this region but it completely remove the region from profiles. Is it safe to simplify (ignore all my testing lines).
Attachment #8730417 - Flags: feedback?(tnikkel)
Comment on attachment 8730417 [details]
MozReview Request: Bug 1256373 - Simplify mMaybeHitRegion. r?tn

Yeah, it should be safe. Only downside is that you might be increasing the dispatch to content region on a layer. It won't decrease the "definitely hit" region though, which is good.
Attachment #8730417 - Flags: feedback?(tnikkel) → feedback+
Comment on attachment 8730417 [details]
MozReview Request: Bug 1256373 - Simplify mMaybeHitRegion. r?tn

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39851/diff/1-2/
Attachment #8730417 - Flags: feedback+
Comment on attachment 8730417 [details]
MozReview Request: Bug 1256373 - Simplify mMaybeHitRegion. r?tn

https://reviewboard.mozilla.org/r/39851/#review37075

Seems okay to me, but kats or someone else should maybe weigh in on if they feel the tradeoff is good.
Attachment #8730417 - Flags: review+
Attachment #8730417 - Flags: review?(bugmail.mozilla)
Comment on attachment 8730417 [details]
MozReview Request: Bug 1256373 - Simplify mMaybeHitRegion. r?tn

This should be fine, I think.
Attachment #8730417 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/7f95bbc4d433
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.