Closed Bug 1256442 Opened 8 years ago Closed 8 years ago

Ship 1.1.x of the Loop system add-on to the release population

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(firefox45+ verified, firefox-esr45 fixed, relnote-firefox 45+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox45 + verified
firefox-esr45 --- fixed
relnote-firefox --- 45+

People

(Reporter: standard8, Assigned: standard8)

References

(
URL
)

Details

(Whiteboard: [btpp-active])

Attachments

(5 files, 1 obsolete file)

[checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45
40 bytes, text/x-github-pull-request
Mardak
: review+
Details | Review
v1.1.14 locale changes
915.99 KB, patch
Sylvestre
: approval-mozilla-release+
Details | Diff | Splinter Review
v1.1.14 Changes for vendor files only used in tests
529.56 KB, patch
Sylvestre
: approval-mozilla-release+
Details | Diff | Splinter Review
v1.1.14 code changes
2.91 MB, patch
Sylvestre
: approval-mozilla-release+
Details | Diff | Splinter Review
v1.1.14 xpi (45 only, use xpinstall.signatures.required=false)
1.55 MB, application/x-xpinstall
Details 
This was discussed with release drivers prior to the 45 release. We'd like to release the 1.1.x version of the system add-on to 45 users via the go faster system.

This bug is for tracking the patches, xpis & the work.
We are working on a 45.0.1 right now (probably going live next Wednesday).
So, they should not go live at the same time!
Comment on attachment 8730388 [details] [review]
[checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45

Here's the changes for our special branch in the github repo:

- Changing the git-export location is just convenience.
- Disabling the menuitem additions is because 45 already adds the menu item for us.
- Min/Max version changes as we only want to work on 45.
- The jar.mn changes are so that we match the build system that's in 45.
Attachment #8730388 - Flags: review?(edilee)
Attachment #8730388 - Flags: review?(dmose)
Comment on attachment 8730388 [details] [review]
[checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45

r=Mardak with maxVersion fix. We'll want to separately fix FIREFOX_VERSION to use .* instead of .0
Attachment #8730388 - Flags: review?(edilee)
Attachment #8730388 - Flags: review?(dmose)
Attachment #8730388 - Flags: review+
Comment on attachment 8730388 [details] [review]
[checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45

https://github.com/mozilla/loop/commit/e55fbd4ea8d9a6533a419e2f54b240e49ebc8292
Attachment #8730388 - Attachment description: [loop] Standard8:v1.1-45-chores > mozilla:v1.1-45 → [checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45
Attached patch v1.1.13 code changes (obsolete) — — Splinter Review 

    
  

        Attachment #8730411 -
        Attachment description: v1.1.13 locale changes → v1.1.14 locale changes

    
  

        Attachment #8730412 -
        Attachment description: v1.1.13 Changes for vendor files only used in tests → v1.1.14 Changes for vendor files only used in tests

    
    

    
  


  
In some additional checks, I noticed the panel wasn't opening after showing the tour, which was due to backing out some of the e10s changes. We've addressed that, and this should now be the "good to go to QA testing" version.

        Attachment #8730413 -
        Attachment is obsolete: true

    
    

    
  


  
This is the v1.1.14 xpi for Firefox 45 only. Should work against 45.0 and 45.0.1 (and any other 45.* versions!).

    
  
Depends on: 1256671

    
    

    
  
Hi Mark, we will need to add a relnote in Firefox 45 release to inform end-users about this change. From comment 3, it was hard for me to tell what end-user facing update do we specifically call out for this push. Please flip relnote-firefox tracking flag and suggest relnote wording.

Also, just wanted to comfirm that this will be a staged rollout to 10% users for the first 24 hrs and to 100% thereafter if all goes well.
Flags: needinfo?(standard8)
Rank: 10
Whiteboard: [btpp-active]

    
    

    
  
(In reply to Ritu Kothari (:ritu) from comment #13)
> Hi Mark, we will need to add a relnote in Firefox 45 release to inform
> end-users about this change. From comment 3, it was hard for me to tell what
> end-user facing update do we specifically call out for this push. Please
> flip relnote-firefox tracking flag and suggest relnote wording.

For the relnote:
New
- Shared pointers when in a Hello session
- Ability to stop sharing tabs when in a Hello session
- Improved UI to share a Hello URL and Facebook Send integration
- Improved first time user tour in Hello

> Also, just wanted to comfirm that this will be a staged rollout to 10% users
> for the first 24 hrs and to 100% thereafter if all goes well.

I think we want to go for 10% rollout for approx first 36-48 hours. 24 is a little bit too short for some of our stats to come in and give us a reasonable assessment.

          relnote-firefox:
          --- → ?
Flags: needinfo?(standard8)

    
    

    
  
(In reply to Mark Banner (:standard8) from comment #14)
> (In reply to Ritu Kothari (:ritu) from comment #13)
> > Hi Mark, we will need to add a relnote in Firefox 45 release to inform
> > end-users about this change. From comment 3, it was hard for me to tell what
> > end-user facing update do we specifically call out for this push. Please
> > flip relnote-firefox tracking flag and suggest relnote wording.
> 
> For the relnote:
> New
> - Shared pointers when in a Hello session
> - Ability to stop sharing tabs when in a Hello session
> - Improved UI to share a Hello URL and Facebook Send integration
> - Improved first time user tour in Hello

Usually relnotes are one-line statements. We will have to think how best to accommodate your suggestion.
> 
> > Also, just wanted to comfirm that this will be a staged rollout to 10% users
> > for the first 24 hrs and to 100% thereafter if all goes well.
> 
> I think we want to go for 10% rollout for approx first 36-48 hours. 24 is a
> little bit too short for some of our stats to come in and give us a
> reasonable assessment.

This makes perfect sense.

    
  
Rank: 10 → 1

    
    

    
  
About the release notes, we can do a single item with a list

Firefox Hello improvements:
  - Shared pointers when in a Hello session
  - Ability to stop sharing tabs when in a Hello session
  - Improved UI to share a Hello URL and Facebook Send integration
  - Improved first time user tour in Hello

    
    

    
  
We tested Hello version 1.1.14 on Firefox 45.0.1 across platforms (Windows 10 64-bit, Windows 7 64-bit, Mac OS X 10.11.1 and Ubuntu 14.04 32-bit) and we did found a few new issues but nothing major that could impact the usability of Hello. Also the update and rollback of the add-on works as expected.

    
    

    
  
Just to complete the record: We started shipping this today @ approx 13:54 UTC at 10% throttle. I'll keep this open until we fully unthrottle.

On the real time stats, I'm starting to see pings from the 1.1.14 version.

    
    

    
  
Hi Mark, as Dan suggested in the email, could we link all the bugs that were fixed in this update to this tracker bug? This will help everybody stay on the same page w.r.t what fixes were pushed in which system add-on update version. Thanks!
Flags: needinfo?(standard8)

    
    

    
  
(In reply to Ritu Kothari (:ritu) from comment #20)
> Hi Mark, as Dan suggested in the email, could we link all the bugs that were
> fixed in this update to this tracker bug? This will help everybody stay on
> the same page w.r.t what fixes were pushed in which system add-on update
> version. Thanks!

For now, I'm going to link to the Changelog (all the changes from 0.1 to 1.1.14). Adding all the bugs is somewhere around 50+ in number and I'd rather spend the time looking to doing that automatically for future releases.

I might be able to use the automation for post-linking onto this bug, if so, I'll add it in.

Note: updates have now been enabled & unthrottled, so marking this as fixed.
URL: https://github.com/mozilla/loop/blob/...
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(standard8)
Resolution: --- → FIXED

    
    

    
  
Ok, I just remembered the other bit. We should probably land the patches in mozilla-release in case there is another dot release required.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Comment on attachment 8730411 [details] [diff] [review]
v1.1.14 locale changes

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello system-addon update.
[User impact if declined]: If there is a dot release and users upgrade, then they'll be temporarily reverted to the previous UI for a period of approximately 24 hours or more - depending on when their FF pings the server for an update, and then when they restart.
[Describe test coverage new/current, TreeHerder]: Released via the go faster system
[Risks and why]: Low, already released code
[String/UUID change made/needed]: None

        Attachment #8730411 -
        Flags: approval-mozilla-release?

    
    

    
  
Comment on attachment 8730412 [details] [diff] [review]
v1.1.14 Changes for vendor files only used in tests

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello system-addon update.
[User impact if declined]: If there is a dot release and users upgrade, then they'll be temporarily reverted to the previous UI for a period of approximately 24 hours or more - depending on when their FF pings the server for an update, and then when they restart.
[Describe test coverage new/current, TreeHerder]: Released via the go faster system
[Risks and why]: Low, already released code
[String/UUID change made/needed]: None

        Attachment #8730412 -
        Flags: approval-mozilla-release?

    
    

    
  
Comment on attachment 8730419 [details] [diff] [review]
v1.1.14 code changes

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello system-addon update.
[User impact if declined]: If there is a dot release and users upgrade, then they'll be temporarily reverted to the previous UI for a period of approximately 24 hours or more - depending on when their FF pings the server for an update, and then when they restart.
[Describe test coverage new/current, TreeHerder]: Released via the go faster system
[Risks and why]: Low, already released code
[String/UUID change made/needed]: None

        Attachment #8730419 -
        Flags: approval-mozilla-release?

    
    

    
  
(In reply to Mark Banner (:standard8) from comment #21)
> (In reply to Ritu Kothari (:ritu) from comment #20)
> > Hi Mark, as Dan suggested in the email, could we link all the bugs that were
> > fixed in this update to this tracker bug? This will help everybody stay on
> > the same page w.r.t what fixes were pushed in which system add-on update
> > version. Thanks!
> 
> For now, I'm going to link to the Changelog (all the changes from 0.1 to
> 1.1.14). Adding all the bugs is somewhere around 50+ in number and I'd
> rather spend the time looking to doing that automatically for future
> releases.
> 
> I might be able to use the automation for post-linking onto this bug, if so,
> I'll add it in.
> 
> Note: updates have now been enabled & unthrottled, so marking this as fixed.

Thanks! I think this should suffice.

    
    

    
  
[Tracking Requested - why for this release]: re-marking as fixed. I'm assuming that if there's a dot release, the patches will get incorporated.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago

          tracking-firefox45:
          --- → ?
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8730411 [details] [diff] [review]
v1.1.14 locale changes

NOT taking it on esr45 as hello is disabled

        Attachment #8730411 -
        Flags: approval-mozilla-release? → approval-mozilla-release+

        Attachment #8730412 -
        Flags: approval-mozilla-release? → approval-mozilla-release+

        Attachment #8730419 -
        Flags: approval-mozilla-release? → approval-mozilla-release+

    
    

    
  
FTR I just had to push https://hg.mozilla.org/releases/mozilla-release/rev/ac2c157c4bd7cd2eca291e0481e3d0b825a24f2b to m-r as well.

It was in the original push set, and I'd forgotten about it this time. Its a build-config only change that makes the l10n repacks work properly.

    
    

    
  
We performed a smoketest on Firefox 45.0.2 build 2 build across platforms (Windows 7 64-bit, Windows 10 32-bit, Mac OS X 10.9.5 and Ubuntu 14.04 64-bit) and can confirm the version of the add-on being 1.1.14. We found three new issues but there were not specific to Firefox 45. 
More details about our testing can be found in this doc: https://goo.gl/tJolXh.
Status: RESOLVED → VERIFIED

          status-firefox45:
          fixed → verified

    
  
Blocks: 1271260

    
  
No longer blocks: 1271260

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: