1256442 - Ship 1.1.x of the Loop system add-on to the release population

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

This was discussed with release drivers prior to the 45 release. We'd like to release the 1.1.x version of the system add-on to 45 users via the go faster system.

This bug is for tracking the patches, xpis & the work.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

We are working on a 45.0.1 right now (probably going live next Wednesday).
So, they should not go live at the same time!

Comment 2

[GitHub Autolander Bot]

Attachment: [checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8730388 [details] [review]
[checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45

Here's the changes for our special branch in the github repo:

- Changing the git-export location is just convenience.
- Disabling the menuitem additions is because 45 already adds the menu item for us.
- Min/Max version changes as we only want to work on 45.
- The jar.mn changes are so that we match the build system that's in 45.

Comment 4

[Ed Lee :Mardak]

Comment on attachment 8730388 [details] [review]
[checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45

r=Mardak with maxVersion fix. We'll want to separately fix FIREFOX_VERSION to use .* instead of .0

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8730388 [details] [review]
[checked in][loop] Standard8:v1.1-45-chores > mozilla:v1.1-45

https://github.com/mozilla/loop/commit/e55fbd4ea8d9a6533a419e2f54b240e49ebc8292

Comment 6

[Mark Banner (:standard8)]

Attachment: v1.1.14 locale changes

Comment 7

[Mark Banner (:standard8)]

Attachment: v1.1.14 Changes for vendor files only used in tests

Comment 8

[Mark Banner (:standard8)]

Attachment: v1.1.13 code changes

Comment 9

[Mark Banner (:standard8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=26aeb093c6b3

Comment 10

[Mark Banner (:standard8)]

Attachment: v1.1.14 code changes

In some additional checks, I noticed the panel wasn't opening after showing the tour, which was due to backing out some of the e10s changes. We've addressed that, and this should now be the "good to go to QA testing" version.

Comment 11

[Mark Banner (:standard8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59659bbc933c

Comment 12

[Mark Banner (:standard8)]

Attachment: v1.1.14 xpi (45 only, use xpinstall.signatures.required=false)

This is the v1.1.14 xpi for Firefox 45 only. Should work against 45.0 and 45.0.1 (and any other 45.* versions!).

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Mark, we will need to add a relnote in Firefox 45 release to inform end-users about this change. From comment 3, it was hard for me to tell what end-user facing update do we specifically call out for this push. Please flip relnote-firefox tracking flag and suggest relnote wording.

Also, just wanted to comfirm that this will be a staged rollout to 10% users for the first 24 hrs and to 100% thereafter if all goes well.

Comment 14

[Mark Banner (:standard8)]

(In reply to Ritu Kothari (:ritu) from comment #13)
> Hi Mark, we will need to add a relnote in Firefox 45 release to inform
> end-users about this change. From comment 3, it was hard for me to tell what
> end-user facing update do we specifically call out for this push. Please
> flip relnote-firefox tracking flag and suggest relnote wording.

For the relnote:
New
- Shared pointers when in a Hello session
- Ability to stop sharing tabs when in a Hello session
- Improved UI to share a Hello URL and Facebook Send integration
- Improved first time user tour in Hello

> Also, just wanted to comfirm that this will be a staged rollout to 10% users
> for the first 24 hrs and to 100% thereafter if all goes well.

I think we want to go for 10% rollout for approx first 36-48 hours. 24 is a little bit too short for some of our stats to come in and give us a reasonable assessment.

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Mark Banner (:standard8) from comment #14)
> (In reply to Ritu Kothari (:ritu) from comment #13)
> > Hi Mark, we will need to add a relnote in Firefox 45 release to inform
> > end-users about this change. From comment 3, it was hard for me to tell what
> > end-user facing update do we specifically call out for this push. Please
> > flip relnote-firefox tracking flag and suggest relnote wording.
> 
> For the relnote:
> New
> - Shared pointers when in a Hello session
> - Ability to stop sharing tabs when in a Hello session
> - Improved UI to share a Hello URL and Facebook Send integration
> - Improved first time user tour in Hello

Usually relnotes are one-line statements. We will have to think how best to accommodate your suggestion.
> 
> > Also, just wanted to comfirm that this will be a staged rollout to 10% users
> > for the first 24 hrs and to 100% thereafter if all goes well.
> 
> I think we want to go for 10% rollout for approx first 36-48 hours. 24 is a
> little bit too short for some of our stats to come in and give us a
> reasonable assessment.

This makes perfect sense.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

About the release notes, we can do a single item with a list

Firefox Hello improvements:
  - Shared pointers when in a Hello session
  - Ability to stop sharing tabs when in a Hello session
  - Improved UI to share a Hello URL and Facebook Send integration
  - Improved first time user tour in Hello

Comment 17

[Bogdan Maris, Desktop Test Engineering]

We tested Hello version 1.1.14 on Firefox 45.0.1 across platforms (Windows 10 64-bit, Windows 7 64-bit, Mac OS X 10.11.1 and Ubuntu 14.04 32-bit) and we did found a few new issues but nothing major that could impact the usability of Hello. Also the update and rollback of the add-on works as expected.

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added this to Fx45 release notes.

Comment 19

[Mark Banner (:standard8)]

Just to complete the record: We started shipping this today @ approx 13:54 UTC at 10% throttle. I'll keep this open until we fully unthrottle.

On the real time stats, I'm starting to see pings from the 1.1.14 version.

Comment 20

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Mark, as Dan suggested in the email, could we link all the bugs that were fixed in this update to this tracker bug? This will help everybody stay on the same page w.r.t what fixes were pushed in which system add-on update version. Thanks!

Comment 21

[Mark Banner (:standard8)]

(In reply to Ritu Kothari (:ritu) from comment #20)
> Hi Mark, as Dan suggested in the email, could we link all the bugs that were
> fixed in this update to this tracker bug? This will help everybody stay on
> the same page w.r.t what fixes were pushed in which system add-on update
> version. Thanks!

For now, I'm going to link to the Changelog (all the changes from 0.1 to 1.1.14). Adding all the bugs is somewhere around 50+ in number and I'd rather spend the time looking to doing that automatically for future releases.

I might be able to use the automation for post-linking onto this bug, if so, I'll add it in.

Note: updates have now been enabled & unthrottled, so marking this as fixed.

Comment 22

[Mark Banner (:standard8)]

Ok, I just remembered the other bit. We should probably land the patches in mozilla-release in case there is another dot release required.

Comment 23

[Mark Banner (:standard8)]

Comment on attachment 8730411 [details] [diff] [review]
v1.1.14 locale changes

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello system-addon update.
[User impact if declined]: If there is a dot release and users upgrade, then they'll be temporarily reverted to the previous UI for a period of approximately 24 hours or more - depending on when their FF pings the server for an update, and then when they restart.
[Describe test coverage new/current, TreeHerder]: Released via the go faster system
[Risks and why]: Low, already released code
[String/UUID change made/needed]: None

Comment 24

[Mark Banner (:standard8)]

Comment on attachment 8730412 [details] [diff] [review]
v1.1.14 Changes for vendor files only used in tests

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello system-addon update.
[User impact if declined]: If there is a dot release and users upgrade, then they'll be temporarily reverted to the previous UI for a period of approximately 24 hours or more - depending on when their FF pings the server for an update, and then when they restart.
[Describe test coverage new/current, TreeHerder]: Released via the go faster system
[Risks and why]: Low, already released code
[String/UUID change made/needed]: None

Comment 25

[Mark Banner (:standard8)]

Comment on attachment 8730419 [details] [diff] [review]
v1.1.14 code changes

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello system-addon update.
[User impact if declined]: If there is a dot release and users upgrade, then they'll be temporarily reverted to the previous UI for a period of approximately 24 hours or more - depending on when their FF pings the server for an update, and then when they restart.
[Describe test coverage new/current, TreeHerder]: Released via the go faster system
[Risks and why]: Low, already released code
[String/UUID change made/needed]: None

Comment 26

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Mark Banner (:standard8) from comment #21)
> (In reply to Ritu Kothari (:ritu) from comment #20)
> > Hi Mark, as Dan suggested in the email, could we link all the bugs that were
> > fixed in this update to this tracker bug? This will help everybody stay on
> > the same page w.r.t what fixes were pushed in which system add-on update
> > version. Thanks!
> 
> For now, I'm going to link to the Changelog (all the changes from 0.1 to
> 1.1.14). Adding all the bugs is somewhere around 50+ in number and I'd
> rather spend the time looking to doing that automatically for future
> releases.
> 
> I might be able to use the automation for post-linking onto this bug, if so,
> I'll add it in.
> 
> Note: updates have now been enabled & unthrottled, so marking this as fixed.

Thanks! I think this should suffice.

Comment 27

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: re-marking as fixed. I'm assuming that if there's a dot release, the patches will get incorporated.

Comment 28

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8730411 [details] [diff] [review]
v1.1.14 locale changes

NOT taking it on esr45 as hello is disabled

Comment 29

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-release/rev/232f8e8e93ef
https://hg.mozilla.org/releases/mozilla-release/rev/45146c0b0917
https://hg.mozilla.org/releases/mozilla-release/rev/dc67c36b137b

Comment 30

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-esr45/rev/ccb4393876d9
Landed to GECKO4501esr_2016031618_RELBRANCH
https://hg.mozilla.org/releases/mozilla-esr45/rev/3afbad2ed04b
Landed to GECKO4501esr_2016031618_RELBRANCH
https://hg.mozilla.org/releases/mozilla-esr45/rev/a451971036ec
Landed to GECKO4501esr_2016031618_RELBRANCH

Comment 31

[Mark Banner (:standard8)]

FTR I just had to push https://hg.mozilla.org/releases/mozilla-release/rev/ac2c157c4bd7cd2eca291e0481e3d0b825a24f2b to m-r as well.

It was in the original push set, and I'd forgotten about it this time. Its a build-config only change that makes the l10n repacks work properly.

Comment 32

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Landed that followup to the relbranch, too: https://hg.mozilla.org/releases/mozilla-esr45/rev/dfb4ee5c0310

Comment 33

[Bogdan Maris, Desktop Test Engineering]

We performed a smoketest on Firefox 45.0.2 build 2 build across platforms (Windows 7 64-bit, Windows 10 32-bit, Mac OS X 10.9.5 and Ubuntu 14.04 64-bit) and can confirm the version of the add-on being 1.1.14. We found three new issues but there were not specific to Firefox 45. 
More details about our testing can be found in this doc: https://goo.gl/tJolXh.