1256447 - Saved tabs open after session restore as new tabs

Status: RESOLVED INCOMPLETE

(Firefox :: Session Restore, defect)

Description

[Sebastian Lammermann]

Attachment: Bildschirmfoto vom 2016-03-14 22-07-37.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160304114936

Steps to reproduce:

After upgrading to Firefox 45 (Ubuntu) I noticed that some of my saved tabs open as new tabs when I click on them.


Actual results:

All tabs still show the website's original favicons but the text "New Tab" (on the image below it's in German = "Neuer Tab"). When I open the tab a blank page appears.

Only a few of my tabs are affected. It is possible that they all came from the same tab group.


Expected results:

The saved tabs should have been loaded.

Comment 1

[Loic]

Maybe dupe of bug 1232955.

What's your cookies policy? Could you attach a screenshot of about:preferences#privacy?

Comment 2

[Sebastian Lammermann]

Attachment: preferences.png

Firefox privacy preferences

Comment 3

[Sebastian Lammermann]

(In reply to Loic from comment #1)
> Maybe dupe of bug 1232955.
> 
> What's your cookies policy? Could you attach a screenshot of
> about:preferences#privacy?

Sure, here it is! It's in German, I hope you don' mind.

Comment 4

[:Gijs (he/him)]

Sorry, simpler question: in about:config, what's the value of:

network.cookie.cookieBehavior

?

Comment 5

[Sebastian Lammermann]

(In reply to :Gijs Kruitbosch from comment #4)
> Sorry, simpler question: in about:config, what's the value of:
> 
> network.cookie.cookieBehavior
> 
> ?

Status integer = 0

Comment 6

[:Gijs (he/him)]

Mike, any other known issues with sessionrestore that could explain this? I'm a little bit out of ideas...

Comment 7

[Sebastian Lammermann]

Actually this bug doesn't kill me. I am able to restore the addresses from my favorites list.

If I am one of a few affected, it might not be worth spending hours in solving this issue.

But if you regard this as a challenge, thank you very much for your support! :D

Comment 8

[Mike Conley (:mconley) (:⚙️)]

This sounds a little bit like something I've been wrestling with in bug 1217904 off and on. Sebastian, if you are able to reproduce this, can you open the browser console (Ctrl-Shift-J) after you've restored your session and either attach the contents in a file here, or email it to me? I want to see if there are any session-related failures being reported in there.

Comment 9

[Sebastian Lammermann]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #8)
> This sounds a little bit like something I've been wrestling with in bug
> 1217904 off and on. Sebastian, if you are able to reproduce this, can you
> open the browser console (Ctrl-Shift-J) after you've restored your session
> and either attach the contents in a file here, or email it to me? I want to
> see if there are any session-related failures being reported in there.

I closed the browser, started it again and klicked on one of the "New Tabs". You find the result attached.

Is this what you need?

Comment 10

[Sebastian Lammermann]

Attachment: console.txt

Comment 11

[Mike Conley (:mconley) (:⚙️)]

I'm afraid that doesn't have anything useful in it.

To be clear, Sebastian, are you hitting this bug every time you restore your session? Consistently?

Comment 12

[Sebastian Lammermann]

It happened the first time after upgrading. Now those tabs are just marked as new tabs and that's it. Firefox does not try to reload the original URI.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

(In reply to Sebastian Lammermann from comment #12)
> It happened the first time after upgrading. Now those tabs are just marked
> as new tabs and that's it. Firefox does not try to reload the original URI.

I see. Since the time that you saw this happen, have you restarted your browser session? Have you seen this behaviour recurring after other browser restarts, beyond the one for upgrading?

Comment 14

[Sebastian Lammermann]

No, all other tabs restored fine and still do. It seems that two groups or so are affected.

Comment 15

[Jerzy]

Attachment: Screenshot of blank tabs after restart

Comment 16

[Jerzy]

I have the same issue. I had multiple tabs opened, then I shut down Firefox and after restarting all my tabs got lost. I can only see "New tab" pages and favicons. No URL, no history, all my tabs are gone (see the attachment 8767175 [details] above). It is really getting on my nerves.

I am allowing cookies and have tracking protection turned on.
My user agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0

Comment 17

[Wayne Mery (:wsmwk)]

(In reply to Mike Conley (:mconley) - (Needinfo me!) from comment #8)
> This sounds a little bit like something I've been wrestling with in bug
> 1217904 off and on. Sebastian, if you are able to reproduce this, can you
> open the browser console (Ctrl-Shift-J) after you've restored your session
> and either attach the contents in a file here, or email it to me? I want to
> see if there are any session-related failures being reported in there.

similar to bug 1225501 with new tab title. But in this bug we see correct favicons.

Comment 18

[Wayne Mery (:wsmwk)]

I just started Firefox nightly with what should have been a 1.3MB session file, and _one_ window of four windows had all (6) "New Tab".  

nd, my windows from the last shutdown were "restored", but my older session (the shutdown prior to this that I had not restored) was gone.

Comment 19

[:Gijs (he/him)]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #18)
> I just started Firefox nightly with what should have been a 1.3MB session
> file, and _one_ window of four windows had all (6) "New Tab".  
> 
> nd, my windows from the last shutdown were "restored", but my older session
> (the shutdown prior to this that I had not restored) was gone.

But can you consistently reproduce this? What add-ons do you have installed? Are there any errors when you select the things that turn into "new tab" when you click them? (Does your experience even exactly match the one in comment #0 where the icons are still website icons, and the new tab page only shows up when you select the tab?).

Comment 20

[Wayne Mery (:wsmwk)]

(In reply to :Gijs Kruitbosch from comment #19)
> (In reply to Wayne Mery (:wsmwk, NI for questions) from comment #18)
> > I just started Firefox nightly with what should have been a 1.3MB session
> > file, and _one_ window of four windows had all (6) "New Tab".  
> > 
> > nd, my windows from the last shutdown were "restored", but my older session
> > (the shutdown prior to this that I had not restored) was gone.
> ...
> (Does your experience even exactly match the one in
> comment #0 where the icons are still website icons, and the new tab page
> only shows up when you select the tab?).

No, but I'm not sure in this case that an exact match is relevant. That said, I've barely begun investigating, and have no idea if what I am seeing is already reported or not.  But there's no lack of reported problems.

> But can you consistently reproduce this? 

Thanks fully no - but I haven't chosen to devote time to it.  OTOH, I have lost session data several times in the past few months

> What add-ons do you have installed?
About 12*. Notable is sessionmanager. Can I absolutely exclude Session manager as a cause, no. But I don't think it is likely involved. And, I haven't been using any of its features - I've been using native firefox session store.

* About sessionstore, copyallurls, flashblock, https-everywhere (only in the last 2 weeks), NTT, restartless restart, revert keyword column, Tabhunter, Theme font and size, treestyletabls, viewabout

> Are there any errors when you select the things that turn into "new tab"
> when you click them? 

In the UI, no. In error console, no

Comment 21

[:Gijs (he/him)]

If you're not using it anyway, disable session manager and see if that fixes it?

Comment 22

[Jerzy]

I am not using Session Manager and still I am affected by this issue. On my short add-ons list are: Tab Groups, Free Memory Button and UnloadTab.

Comment 23

[:Gijs (he/him)]

(In reply to Jerzy from comment #22)
> I am not using Session Manager and still I am affected by this issue. On my
> short add-ons list are: Tab Groups, Free Memory Button and UnloadTab.

https://addons.mozilla.org/en-GB/firefox/addon/unloadtab/

all the reviews AMO shows are reporting exactly the problem this bug got filed about. Seems pretty likely it's caused by that add-on.

Comment 24

[Wayne Mery (:wsmwk)]

(In reply to :Gijs Kruitbosch from comment #23)
> ...
> short add-ons list are: Tab Groups, Free Memory Button and UnloadTab.
> 
> https://addons.mozilla.org/en-GB/firefox/addon/unloadtab/
> 
> all the reviews AMO shows are reporting exactly the problem this bug got
> filed about. Seems pretty likely it's caused by that add-on.

Sebastian, what addons are you using?

Comment 25

[B.J. Herbison]

I have started seeing this problem with Nightly in the past two days.

Comment 26

[Wayne Mery (:wsmwk)]

Sebastian seems to be gone - I had PMed him in 2017 and no reply