Closed Bug 1256461 Opened 4 years ago Closed 4 years ago

merge MoveChild and SeizeChild methods

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: surkov, Assigned: surkov)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8730398 - Flags: review?(yzenevich)
Comment on attachment 8730398 [details] [diff] [review]
patch

Review of attachment 8730398 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good , just one question

::: accessible/generic/DocAccessible.cpp
@@ +2181,5 @@
> +    nsTArray<RefPtr<Accessible> >* children = mARIAOwnsHash.Get(curParent);
> +    children->RemoveElement(aChild);
> +  }
> +
> +  if (curParent == aNewParent) {

Is it ever possible that aIdxInParent is the same as child's current index in parent? Would we want to account for that case at all?
Attachment #8730398 - Flags: review?(yzenevich) → review+
You mean no-move case? I will add an assertion.
https://hg.mozilla.org/mozilla-central/rev/dbb5c40ec3a2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee: nobody → surkov.alexander
Depends on: CVE-2017-7818
You need to log in before you can comment on or make changes to this bug.