Closed
Bug 1256461
Opened 8 years ago
Closed 8 years ago
merge MoveChild and SeizeChild methods
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: surkov, Assigned: surkov)
References
Details
Attachments
(1 file)
11.44 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8730398 -
Flags: review?(yzenevich)
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15f4016dd65d
Comment 2•8 years ago
|
||
Comment on attachment 8730398 [details] [diff] [review] patch Review of attachment 8730398 [details] [diff] [review]: ----------------------------------------------------------------- Looks good , just one question ::: accessible/generic/DocAccessible.cpp @@ +2181,5 @@ > + nsTArray<RefPtr<Accessible> >* children = mARIAOwnsHash.Get(curParent); > + children->RemoveElement(aChild); > + } > + > + if (curParent == aNewParent) { Is it ever possible that aIdxInParent is the same as child's current index in parent? Would we want to account for that case at all?
Attachment #8730398 -
Flags: review?(yzenevich) → review+
Assignee | ||
Comment 3•8 years ago
|
||
You mean no-move case? I will add an assertion.
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=53e9b878a1d5
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbb5c40ec3a2ef633a55187f2f260ec098f18932 Bug 1256461 - merge MoveChild and SeizeChild methods, r=yzen
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dbb5c40ec3a2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
Assignee: nobody → surkov.alexander
Updated•7 years ago
|
Depends on: CVE-2017-7818
You need to log in
before you can comment on or make changes to this bug.
Description
•