Closed Bug 1256484 Opened 6 years ago Closed 6 years ago

security\pkix\include\pkix/Input.h(87): warning C4458: declaration of 'data' hides class member

Categories

(Core :: Security: PSM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We're seeing a number of C4456 and C4458 warnings turned into errors when building with VS2015u1.

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(87): error C2220: warning treated as error - no 'object' file generated

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(87): warning C4458: declaration of 'data' hides class member

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(87): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(126): note: see declaration of 'mozilla::pkix::Input::data'

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(87): warning C4458: declaration of 'len' hides class member

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(87): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(127): note: see declaration of 'mozilla::pkix::Input::len'

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(162): warning C4458: declaration of 'input' hides class member

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(162): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\pkix\include\pkix/Input.h(324): note: see declaration of 'mozilla::pkix::Reader::input'

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\manager\ssl\ScopedNSSTypes.h(157): warning C4458: declaration of 'buf' hides class member

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\manager\ssl\ScopedNSSTypes.h(157): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

 16:16:27     INFO -  c:\builds\moz2_slave\try-w32-0000000000000000000000\build\src\security\manager\ssl\ScopedNSSTypes.h(207): note: see declaration of 'mozilla::Digest::buf'

 16:16:27     INFO -  c:/builds/moz2_slave/try-w32-0000000000000000000000/build/src/security/certverifier/OCSPRequestor.cpp(171): warning C4456: declaration of 'rv' hides previous local declaration

 16:16:27     INFO -  c:/builds/moz2_slave/try-w32-0000000000000000000000/build/src/security/certverifier/OCSPRequestor.cpp(171): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

16:16:27 INFO - c:/builds/moz2_slave/try-w32-0000000000000000000000/build/src/security/certverifier/OCSPRequestor.cpp(100): note: see declaration of 'rv'
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
someone fixes the underlying problem someday. However, there are tons
of ignored warnings in security/certverifier, so I guess the workaround
in this patch is par for the course.

Review commit: https://reviewboard.mozilla.org/r/39871/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39871/
https://reviewboard.mozilla.org/r/39871/#review36507

Just as a friendly FYI, your r? request didn't work because you used "dkeeler" instead of "keeler".
(Sadly, it looks like I can't change it for you).
Attachment #8730442 - Flags: review?(dkeeler)
Comment on attachment 8730442 [details]
MozReview Request: Bug 1256484 - Disable C4456 and C4458 to unblock compilation on VS2015; r?keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39871/diff/1-2/
Attachment #8730442 - Attachment description: MozReview Request: Bug 1256484 - Disable C4456 and C4458 to unblock compilation on VS2015; r?dkeeler → MozReview Request: Bug 1256484 - Disable C4456 and C4458 to unblock compilation on VS2015; r?keeler
Comment on attachment 8730442 [details]
MozReview Request: Bug 1256484 - Disable C4456 and C4458 to unblock compilation on VS2015; r?keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39871/diff/2-3/
Comment on attachment 8730442 [details]
MozReview Request: Bug 1256484 - Disable C4456 and C4458 to unblock compilation on VS2015; r?keeler

https://reviewboard.mozilla.org/r/39871/#review36663

Yeah, this is sort-of of unfortunate, but it's not worse than what we're already doing.
Attachment #8730442 - Flags: review?(dkeeler) → review+
Assignee: nobody → gps
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/64657769538c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Blocks: 1259320
You need to log in before you can comment on or make changes to this bug.