Closed Bug 1256501 Opened 4 years ago Closed 4 years ago
Window .cpp(2210): warning C4312: 'reinterpret _cast': conversion from 'int' to 'HANDLE' of greater size
MozReview Request: Bug 1256501: Fix warning C4312 with 64-bit VS2015 in widget/windows/nsWindow.cpp; r?jimm
58 bytes, text/x-review-board-request
We're seeing this warning turned into an error when building with VS2015u1 in automation.
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. Review commit: https://reviewboard.mozilla.org/r/39893/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39893/
Review commit: https://reviewboard.mozilla.org/r/41495/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41495/
Attachment #8732991 - Flags: review?(jmathies)
Comment on attachment 8730465 [details] MozReview Request: Bug 1256501 - Disable C4312 to unblock compilation on VS2015; r?aklotz https://reviewboard.mozilla.org/r/39893/#review37939 I'll land a proper fix for this one.
Comment on attachment 8732991 [details] MozReview Request: Bug 1256501: Fix warning C4312 with 64-bit VS2015 in widget/windows/nsWindow.cpp; r?jimm https://reviewboard.mozilla.org/r/41495/#review38023
Attachment #8730465 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.