Closed Bug 1256502 Opened 8 years ago Closed 8 years ago

gfx/ipc/SharedDIBWin.cpp(16): warning C4319: '~': zero extending 'uint32_t' to 'size_t' of greater size

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gps, Unassigned)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file, 1 obsolete file)

We're seeing this warning turned into an error when building with VS2015u1 in automation.
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/39897/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39897/
Whiteboard: gfx-noted
Blocks: 1124033
The sizeof() was creating a size_t which made VS complain about a
mismatch between uint32_t and size_t. The sizeof() should never be
larger than a uint32_t, so just cast it.

Review commit: https://reviewboard.mozilla.org/r/42093/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42093/
Attachment #8730466 - Attachment is obsolete: true
Comment on attachment 8734131 [details]
MozReview Request: Bug 1256502 - Use a uint32_t cast to avoid C4319 on VS2015; r?jmuizelaar

https://reviewboard.mozilla.org/r/42093/#review38625

Drive-by r+
Attachment #8734131 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9b6ff1fc5e7a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.