Closed Bug 1256505 Opened 4 years ago Closed 4 years ago

layout/base/nsFrameManager.cpp(67): warning C4312: 'type cast': conversion from 'unsigned int' to 'void *' of greater size

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This warning is getting turned into an error on Visual Studio 2015 Update 1 in automation.
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/39905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39905/
Attachment #8730470 - Flags: review?(birunthan)
Comment on attachment 8730470 [details]
MozReview Request: Bug 1256505 - Disable C4312 to unblock compilation on VS2015; r?poiru

https://reviewboard.mozilla.org/r/39905/#review36491
Attachment #8730470 - Flags: review?(birunthan) → review+
Assignee: nobody → gps
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c19d7ab6f3ba
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Blocks: 1259315
You need to log in before you can comment on or make changes to this bug.