icu\source\common\unicode/ucasemap.h(93): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc

RESOLVED FIXED in Firefox 48

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We're seeing this warning turned into an error when building layout/forms unified sources with VS2015u1 in automation.
(Assignee)

Comment 1

2 years ago
Created attachment 8730474 [details]
MozReview Request: Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r?poiru

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary. That being said, the warning occurs in 3rd party ICU
code. So I'm not sure what my options are for fixing this.

Review commit: https://reviewboard.mozilla.org/r/39913/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39913/
Attachment #8730474 - Flags: review?(birunthan)
Comment on attachment 8730474 [details]
MozReview Request: Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r?poiru

https://reviewboard.mozilla.org/r/39913/#review36493
Attachment #8730474 - Flags: review?(birunthan) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → gps
Status: NEW → ASSIGNED

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8882a15789b0
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
(Assignee)

Updated

2 years ago
Blocks: 1257323
You need to log in before you can comment on or make changes to this bug.