Closed Bug 1256514 Opened 4 years ago Closed 4 years ago
.h(93): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed . Specify /EHsc
58 bytes, text/x-review-board-request
We're seeing this warning turned into an error when building intl/unicharutil with VS2015u1 in automation.
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. Review commit: https://reviewboard.mozilla.org/r/39935/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39935/
Attachment #8730487 - Flags: review?(birunthan)
Attachment #8730487 - Flags: review?(birunthan) → review+
Comment on attachment 8730487 [details] MozReview Request: Bug 1256514 - Disable C4577 to unblock compilation on VS2015; r?poiru https://reviewboard.mozilla.org/r/39935/#review36489
You need to log in before you can comment on or make changes to this bug.