"Add new jobs" does not show any job if classified jobs are filtered out

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: xidorn, Assigned: camd)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
It seems if I set the filter to exclude manually classified jobs, nothing would show when I want to add new jobs via the dropdown menu, which should probably be fixed.

Comment 1

2 years ago
Thanks xidorn for filling. I will look into it this week. I was away for a couple of weeks.
Assignee: nobody → armenzg

Comment 2

2 years ago
What are "manually classified jobs"?
Do you have steps to reproduce?

From reading again, this is not likely a pulse_actions bug and I will need a hand from camd or emorley.
Assignee: armenzg → nobody
(Reporter)

Comment 3

2 years ago
str
Steps to reproduce:
1. open treeherder for whatever try push, e.g. https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca8c629746eb
2. click the "Filters" in the top bar
3. in the expanded panel, inside "manual classification" group, uncheck "classified"
4. expand the menu for the try push and click "Add new Jobs"

Expected result:
New jobs show as normal.

Actual result:
No job is shown until you re-check "classified".

Comment 4

2 years ago
Thanks! I can reproduce it. It will have to wait on a treeherder dev to look at this.
(Assignee)

Comment 5

2 years ago
Yeah, this isn't a bug in the "add new jobs" feature.  This is really in our filtering code.  I think I must have caused this regression.  I'll take a look at fixing this.
(Assignee)

Updated

2 years ago
Assignee: nobody → cdawson
Created attachment 8745076 [details] [review]
[treeherder] mozilla:add-new-job-unclassified > mozilla:master
(Assignee)

Updated

2 years ago
Attachment #8745076 - Flags: review?(wlachance)
Comment on attachment 8745076 [details] [review]
[treeherder] mozilla:add-new-job-unclassified > mozilla:master

This sounds fine, we should be sure to do a moztrap run before deploying to production just in case.
Attachment #8745076 - Flags: review?(wlachance) → review+

Comment 8

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f09fb7f7c70714dcbcde9a1768a138d1dd6ab4a1
Bug 1256519 - Show 'Add new jobs' when classified jobs are filtered out
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.