1256622 - Allow to build spidermonkey from the top-level configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

To bootstrap the transition of spidermonkey builds from js/src/configure to using top-level configure, we should allow both to work, and it should actually be possible. The notable difference I would like to be when using top-level configure is that it would read a mozconfig (and expect --enable-project=js there or on the command line).

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1256622 - Allow to build spidermonkey from the top-level configure

Review commit: https://reviewboard.mozilla.org/r/40245/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40245/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8730937 [details]
MozReview Request: Bug 1256622 - Allow to build spidermonkey from the top-level configure

https://reviewboard.mozilla.org/r/40245/#review36773

Given the typo I found, I'm surprised this worked at all. So I'm holding off granting review in case fixing the typo breaks things. Ping me on IRC if you want me to grant a quick r+ on the fixup once you confirm it works.

::: build/moz.configure/old.configure:103
(Diff revision 1)
>      # as $0, and backslashes there breaks autoconf's detection of the source
>      # directory.
>      old_configure = os.path.abspath(old_configure[0])
> +    if build_project == 'js':
> +        old_configure_dir = os.path.dirname(old_configure)
> +        if not old_configure.endswith('/js/src'):

Shouldn't this be old_configure_dir since `old_configure` points to a file?

Comment 3

[Mike Hommey [:glandium]]

That's because I only tested building js, not firefox. facepalm.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8730937 [details]
MozReview Request: Bug 1256622 - Allow to build spidermonkey from the top-level configure

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40245/diff/1-2/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8730937 [details]
MozReview Request: Bug 1256622 - Allow to build spidermonkey from the top-level configure

https://reviewboard.mozilla.org/r/40245/#review36785

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94f3363ab6dd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/94f3363ab6dd