Closed Bug 1256672 Opened 4 years ago Closed 4 years ago

Refactor OOM simulation infrastructure

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch refactor-oom-simulation (obsolete) — Splinter Review
Here's a patch to abstract the OOM simulation infrastructure a little.

Since there were a couple of issues in the past with counters overflowing 32 bits, I made them 64 bits instead.
Attachment #8730721 - Flags: review?(terrence)
Updated to fix signed/unsigned conversion warnings on Windows builds.
Attachment #8730721 - Attachment is obsolete: true
Attachment #8730721 - Flags: review?(terrence)
Attachment #8730852 - Flags: review?(terrence)
Comment on attachment 8730852 [details] [diff] [review]
refactor-oom-simulation v2

Review of attachment 8730852 [details] [diff] [review]:
-----------------------------------------------------------------

Most excellent!
Attachment #8730852 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/4b003bd6f736
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.