1256681 - Upcoming autocomplete-richlistitem toolkit changes for Firefox will affect Thunderbird global search (gloda

Status: RESOLVED WORKSFORME

(Thunderbird :: Upstream Synchronization, defect)

Description

[Drew Willcoxon :adw]

In bug 1181078, we're rewriting autocomplete-richlistitem [1] to match a new design spec for Firefox's awesomebar popup.  Marco mentioned that Thunderbird uses richlist autocomplete, so our changes would affect it.  I'm filing this bug to let you know about the changes and to try to minimize disruption to Thunderbird.

The design spec is here (from bug 959564): http://people.mozilla.org/~shorlander/mockups/AwesomeResults/AwesomeResults-01.html

The changes are mostly visual.  Instead of showing URLs and action text below titles, they're now shown after titles.  The current patch changes some class names and moves things around though.

Here's the markup from the current patch:

  <content align="center"
           onoverflow="this._onOverflow();"
           onunderflow="this._onUnderflow();">
    <xul:image anonid="type-icon"
               class="ac-type-icon"
               xbl:inherits="selected,current"/>
    <xul:image anonid="site-icon"
               class="ac-site-icon"
               xbl:inherits="src=image,selected"/>
    <xul:hbox class="ac-title"
              align="center"
              xbl:inherits="selected">
      <xul:description class="ac-text-overflow-container">
        <xul:description anonid="title-text"
                         class="ac-title-text"
                         xbl:inherits="selected"/>
      </xul:description>
    </xul:hbox>
    <xul:hbox class="ac-url"
              align="center"
              xbl:inherits="selected,actiontype">
      <xul:description class="ac-text-overflow-container">
        <xul:description anonid="url-text"
                         class="ac-url-text"
                         xbl:inherits="selected"/>
      </xul:description>
    </xul:hbox>
    <xul:hbox class="ac-action"
              align="center"
              xbl:inherits="selected,actiontype">
      <xul:description class="ac-text-overflow-container">
        <xul:description anonid="action-text"
                         class="ac-action-text"
                         xbl:inherits="selected"/>
      </xul:description>
    </xul:hbox>
  </content>

A few things are removed altogether: the ellipsis overflow mechanism, in favor of `text-overflow: ellipsis` CSS; the .ac-action-icon image, in favor of showing action icons using the .ac-type-icon image; and the .ac-extra hbox.  Would any of that be a problem for Thunderbird?  Stephen's spec doesn't currently account for tags in Firefox, which is what we use .ac-extra for, so we may end up adding that back somehow.

CC'ing some people who've been involved with Thunderbird in the past.  Apologies if I'm missing anyone important or CC'ing the wrong people.  Please feel free to remove yourself.

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/autocomplete.xml?rev=2323e6b411c1#1325

Comment 1

[Mark Banner (:standard8)]

Thanks for the cc but I'm not involved any more. Adding a couple of people that are.

Comment 2

[Kent James (:rkent)]

Magnus has done a lot of auto complete work in Thunderbird.

Comment 3

[Marco Bonardo [:mak]]

I think currently richlist AC is used by gloda.

Comment 4

[Marco Bonardo [:mak]]

Changes are in Nightly.

Comment 5

[Wayne Mery (:wsmwk)]

Is this still needed?

Comment 6

[Magnus Melin [:mkmelin]]

No.