Closed
Bug 1256688
Opened 8 years ago
Closed 8 years ago
Change implementation of BaseProxyHandler::has() to follow ES6 [[HasProperty]] specification
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
Attachments
(3 files)
4.15 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
1.26 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
1.14 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Same idea as bug 1083211. The biggest advantage here is the removal of the getPropertyDescriptor call. Sadly Sandbox and Xray still require the old getPropertyDescriptor based semantics.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → evilpies
Assignee | ||
Comment 1•8 years ago
|
||
This also removes the DOMProxyHandler override, because it is basically a copy of the new implementation expressed differently.
Attachment #8731594 -
Flags: review?(jorendorff)
Assignee | ||
Comment 2•8 years ago
|
||
This is just what we did in Bug 1242072 for ::get. It is the simplest solution for having this continue to work before somebody does a deeper fix for Xrays.
Attachment #8731596 -
Flags: review?(peterv)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8731599 -
Flags: review?(peterv)
Comment 4•8 years ago
|
||
Comment on attachment 8731596 [details] [diff] [review] Continue using getPropertyDescriptor for has in XrayWrapper Review of attachment 8731596 [details] [diff] [review]: ----------------------------------------------------------------- :-(.
Attachment #8731596 -
Flags: review?(peterv) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8731599 [details] [diff] [review] Continue using getPropertyDescriptor for has in Sandbox Review of attachment 8731599 [details] [diff] [review]: ----------------------------------------------------------------- Would calling JS_HasPropertyById on wrappedObject(proxy) be equivalent?
Attachment #8731599 -
Flags: review?(peterv) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8731594 [details] [diff] [review] Change BPH::has to follow [[HasProperty]] for ordinary objects Review of attachment 8731594 [details] [diff] [review]: ----------------------------------------------------------------- Yes please.
Attachment #8731594 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Peter Van der Beken [:peterv] from comment #5) > Comment on attachment 8731599 [details] [diff] [review] > Continue using getPropertyDescriptor for has in Sandbox > > Review of attachment 8731599 [details] [diff] [review]: > ----------------------------------------------------------------- > > Would calling JS_HasPropertyById on wrappedObject(proxy) be equivalent? I think so in this case. I am working on patches to remove getPropertyDescriptor completely, so I will figure this out soon anyway.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db58032977a https://hg.mozilla.org/integration/mozilla-inbound/rev/3f5ac8a1b956 https://hg.mozilla.org/integration/mozilla-inbound/rev/94f67b8f0583
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7db58032977a https://hg.mozilla.org/mozilla-central/rev/3f5ac8a1b956 https://hg.mozilla.org/mozilla-central/rev/94f67b8f0583
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•