Closed
Bug 1256694
Opened 8 years ago
Closed 8 years ago
Loop should use MOZ_APP_MAXVERSION to generate the maximum supported Firefox version number to correctly support security builds
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox48 fixed)
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
(Whiteboard: [btpp-fix-now])
Attachments
(2 files)
If, for example, we produce an xpi that works with 45.0, but we want to supply it to someone that has 45.0.1, or there's some weird fallback option we need to supply for the Go faster system, then currently our xpi's won't work - they have a maximum version of "45.0". We should change it to be "45.*" so that we can always have the right compatibility profile.
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8730777 [details] [review] [loop] Standard8:bug-1256694-maxver > mozilla:master This uses the same variable as mozilla-central, so that we can export the install.rdf easily. I've also switched to using preprocessor.py since we're using that for the prefs.js stuff now.
Attachment #8730777 -
Flags: review?(edilee)
Comment 3•8 years ago
|
||
Comment on attachment 8730777 [details] [review] [loop] Standard8:bug-1256694-maxver > mozilla:master Put a question in PR about simplifying to not need `sed`.
Attachment #8730777 -
Flags: review?(edilee) → feedback+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8730777 [details] [review] [loop] Standard8:bug-1256694-maxver > mozilla:master I updated the PR.
Attachment #8730777 -
Flags: review?(edilee)
Updated•8 years ago
|
Attachment #8730777 -
Flags: review?(edilee) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://github.com/mozilla/loop/commit/0af900bef7853484ef5737c2786424ee7397b973
Status: NEW → RESOLVED
Iteration: --- → 48.1 - Mar 21
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•8 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•8 years ago
|
||
I just realised whilst doing an export that we're not quite done here. We need a define for the MOZ_APP_MAXVERSION to be specified in the moz.build file.
Attachment #8731658 -
Flags: review?(mh+mozilla)
Updated•8 years ago
|
Rank: 15
Updated•8 years ago
|
Attachment #8731658 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/852ac8a4ec55b93df8c9740aafaee6b84f539c3d Bug 1256694 - Loop should use MOZ_APP_MAXVERSION to generate the maximum supported Firefox version number to correctly support security builds (build sytem part). r=glandium
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/852ac8a4ec55
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•