12567 - create win32/unix manifest parser perl script

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Jon Granrose]

Made a lot of progress on this.  I'm about 90% done.  It does

- individual file copies
- recursive directory copies
- deletion of files or directories from the destination directory
- specification of an alternate destination (for both file and dir copies)

The only thing really left is globbing to allow wildcards.  It is currently at
buell.mcom.com:/builds/pkgcp.pl if you want to take a look, and I am waiting for
a cvs account in order to check it in which should happen Tuesday.  I'll also
finish the wildcard feature as well.  I've done a fair amount of testing and
error checking, but will need some working package files to test against.  Once
it's all happy on Linux, I'll look to porting it to win32 and possibly Mac.

Comment 1

[Chris Yeh]

excellent. i have the power to issue you a cvs account, let me do that now.

Comment 2

[Jon Granrose]

My CVS account is up and running.  leaf just walked me through checking in the
file and it's in there:

RCS file: /cvsroot/mozilla/xpinstall/packager/pkgcp.pl,v
done
Checking in pkgcp.pl;
/cvsroot/mozilla/xpinstall/packager/pkgcp.pl,v  <--  pkgcp.pl
initial revision: 1.1
done


Comments, copying individual files, redirecting individual files, and wildcards
all work.

Problem areas:
- recursively copying and/or redirecting directories.
- using a relative path for the dest dir (presently has to be an absolute path).

Should have these problems sorted out later this week.

Comment 3

[Chris Yeh]

just noticed a bug:
you need to maintain file permission flags when you move, so that if an item is
marked executable, it maintains that flag. i think you can do this by setting
umask(0);, but not sure.

Comment 4

[Jon Granrose]

unix copy now gets the permissions of the source file and sets the destination
file the same.  need to revisit central copy procedure to work better XP and
improve the performance a bit.

Comment 5

[Jon Granrose]

still working on this.

cleaning up the central do_copyfile routine.  reducing recursion and improving
performance.

Comment 6

[Jon Granrose]

many changes in my copy, waiting for leaf to complete his packages-win updates
before checking in so I can test the new script on the new package.

Comment 7

[Jon Granrose]

worked w/jj on mac port.  macperl doesn't like globbing, so checked in
workaround so that any globbing to copy an entire directory (e.g. dir:dir:*)
strips off the :* and does a copydir on dir:dir, and any other globbing it
prints out a warning with a suggestion to copy the entire directory.

This is good enough to use and create/maintain a packages-mac file.  Will
research the macperl globbing to see if we can find out how to get it to work.
It appears to not like variables.  So if I do a `glob *.pl` it finds all the .pl
files, but if I pass it a var containing *.pl, it doesn't find anything...

Comment 8

[Jon Granrose]

not going to make M11.

Comment 9

[Jon Granrose]

this is basically done.  got the feedback on the mac globbing, but might have to
make do with what we have.  closing.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc77f65a4d83
[fenix] Fix nav graph and theme tests (https://github.com/mozilla-mobile/fenix/pull/12567)