Closed Bug 1256704 Opened 5 years ago Closed 5 years ago
Conditional Breakpoints are set to line 1
It looks like adding a conditional breakpoint via the Context Menu will cause breakpoints to be added to line 1. Here's an example: http://recordit.co/Pb922ewVAG
This patch makes `_onCmdAddConditionalBreakpoint` consistent with `_onCmdAddBreakpoint`. I'm not sure, if there was a reason that conditional breakpoints were handling setting line differently. I believe the error came from this expression (e && e.sourceEvent.target.tagName == 'menuitem') being resolved to true when the user selects "add conditional breakpoints" from the contextmenu.
This is basic functionality that should just work, so assigning P1 to this.
Priority: -- → P1
Awesome, thank you! Yes, we forgot to also update that function.
You need to log in before you can comment on or make changes to this bug.