Closed Bug 1256704 Opened 8 years ago Closed 8 years ago

Conditional Breakpoints are set to line 1

Categories

(DevTools :: Debugger, defect, P1)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox48 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: jlast, Unassigned)

Details

Attachments

(1 file)

1256704.patch
1.22 KB, patch
jlong
: review+
Details | Diff | Splinter Review 
It looks like adding a conditional breakpoint via the Context Menu will cause breakpoints to be added to line 1.

Here's an example:
http://recordit.co/Pb922ewVAG
Attached patch 1256704.patch — — Splinter Review 

        Attachment #8730804 -
        Flags: review?(jlong)

    
    

    
  
This patch makes `_onCmdAddConditionalBreakpoint` consistent with `_onCmdAddBreakpoint`. I'm not sure, if there was a reason that conditional breakpoints were handling setting line differently.

I believe the error came from this expression (e && e.sourceEvent.target.tagName == 'menuitem') being resolved to true when the user selects "add conditional breakpoints" from the contextmenu.

    
    

    
  
This is basic functionality that should just work, so assigning P1 to this.
Priority: -- → P1

    
    

    
  
Awesome, thank you! Yes, we forgot to also update that function.

        Attachment #8730804 -
        Flags: review?(jlong) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/23c05cd9fcf5
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox48:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.