Ctrl-clicking a pinned job should toggle pinning

RESOLVED FIXED

Status

Tree Management
Treeherder
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sfink, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
When I ctrl-click a job, it pins it, which is good. But I can't unpin jobs by ctrl-clicking them again, as I expected.
Priority: -- → P2
Created attachment 8763241 [details] [review]
[treeherder] KWierso:1256751 > mozilla:master
(Assignee)

Updated

2 years ago
Assignee: nobody → wkocher
(Assignee)

Comment 2

2 years ago
Comment on attachment 8763241 [details] [review]
[treeherder] KWierso:1256751 > mozilla:master

This makes Ctrl-click toggle pinning.
Spacebar remains as always pinning with this.
Don't know if I'm happy or sad about that.
Attachment #8763241 - Flags: review?(cdawson)

Updated

2 years ago
Attachment #8763241 - Flags: review?(cdawson) → review+

Comment 3

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/de914a1cd2846e38ace2769b329042c3e83e3a69
Bug 1256751 - Make ctrl-click toggle pinning, not just pinning always (#1603) r=camd

* Bug 1256751 - Make ctrl-click toggle pinning, not just pinning always

* Update thShortcutTable for the new toggle action
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.