Closed Bug 1256751 Opened 8 years ago Closed 8 years ago

Ctrl-clicking a pinned job should toggle pinning

Categories

(Tree Management :: Treeherder, defect, P2)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sfink, Assigned: KWierso)

Details

Attachments

(1 file)

[treeherder] KWierso:1256751 > mozilla:master
47 bytes, text/x-github-pull-request
camd
: review+
Details | Review 
When I ctrl-click a job, it pins it, which is good. But I can't unpin jobs by ctrl-clicking them again, as I expected.
Priority: -- → P2
Assignee: nobody → wkocher
Comment on attachment 8763241 [details] [review]
[treeherder] KWierso:1256751 > mozilla:master

This makes Ctrl-click toggle pinning.
Spacebar remains as always pinning with this.
Don't know if I'm happy or sad about that.
Attachment #8763241 - Flags: review?(cdawson)
Attachment #8763241 - Flags: review?(cdawson) → review+
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/de914a1cd2846e38ace2769b329042c3e83e3a69
Bug 1256751 - Make ctrl-click toggle pinning, not just pinning always (#1603) r=camd

* Bug 1256751 - Make ctrl-click toggle pinning, not just pinning always

* Update thShortcutTable for the new toggle action
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: