Closed
Bug 1256766
Opened 7 years ago
Closed 7 years ago
Make sure youtube flash rewrite tests work when pref is turned off
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: qdot, Assigned: qdot)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
4.64 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The tests for bug 769117 assume the pref is always on, which may not be the case. The test should account for the pref being off and turn it on when needed.
Assignee | ||
Comment 2•7 years ago
|
||
Hoping to get to it soon, just been a lot of things piling up.
Flags: needinfo?(kyle)
Updated•7 years ago
|
Whiteboard: btpp-active
Assignee | ||
Comment 3•7 years ago
|
||
Update of test from bug 769117. Just need to delay loading of static tags until after pref is set, so moving those into an iframe.
Attachment #8740202 -
Flags: review?(bzbarsky)
![]() |
||
Comment 4•7 years ago
|
||
Comment on attachment 8740202 [details] [diff] [review] Patch 1 (v1) - Make sure all objects load afer pref set for youtube rewrite test r=me
Attachment #8740202 -
Flags: review?(bzbarsky) → review+
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/345e0864f665
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•