1256774 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_bug_638949_copy_link_location.js

Status: RESOLVED WONTFIX

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_bug_638949_copy_link_location.js

Comment 1

[simplyblue24]

Attachment: 1256774.patch

Hi,please review my patch

Comment 2

[Jason Laster [:jlast]]

Hi simplyblue, linclark would be a better reviewer.

Comment 3

[Lin Clark [:linclark]]

Comment on attachment 8739372 [details] [diff] [review]
1256774.patch

Review of attachment 8739372 [details] [diff] [review]:
-----------------------------------------------------------------

This one looks good to. Feel free to add the checkin-needed keyword

Comment 5

[Brian Grinstead [:bgrins]]

When I test this out with the patch applied, I'm still seeing some eslint errors:

  29:3   error    content is a possible Cross Process Object Wrapper (CPOW)                 mozilla/no-cpows-in-tests
  45:3   error    'goUpdateCommand' is not defined                                          no-undef
  50:9   error    'waitForContextMenu' is not defined                                       no-undef
  57:3   error    content is a possible Cross Process Object Wrapper (CPOW)                 mozilla/no-cpows-in-tests
  75:3   error    'goUpdateCommand' is not defined                                          no-undef
  80:18  error    'promise' is not defined                                                  no-undef
  85:5   error    'goDoCommand' is not defined                                              no-undef
  96:9   error    'waitForContextMenu' is not defined                                       no-undef

Can you please take a look?  This is when running: ./mach eslint --no-ignore devtools/client/webconsole/test/browser_bug_638949_copy_link_location.js

For the no-cpows-in-tests issue you'll need to wrap any calls to content inside a ContentTask.spawn, i.e.

  ContentTask.spawn(gBrowser.selectedBrowser, {}, function* () {
    content.console.log("bug 638949");
  });