Closed Bug 1256794 Opened 4 years ago Closed 3 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_private_browsing.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: mkohler, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_private_browsing.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Assignee: nobody → me
Status: NEW → ASSIGNED
Attachment #8750017 - Flags: review?(jlaster)
Comment on attachment 8750017 [details] [diff] [review]
0001-Bug-1256794-ESLint.patch

Review of attachment 8750017 [details] [diff] [review]:
-----------------------------------------------------------------

https://bugzilla.mozilla.org/attachment.cgi?id=8750017&action=diff#a/devtools/client/webconsole/test/browser_console_private_browsing.js_sec2

> ContentTask.spawn(gBrowser.selectedBrowser, null, function* () {
>     content.console.log("bug874061-not-private");
> });

why is this necessary?
(In reply to Jason Laster [:jlast] from comment #3)
> Comment on attachment 8750017 [details] [diff] [review]
> 0001-Bug-1256794-ESLint.patch
> 
> Review of attachment 8750017 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> https://bugzilla.mozilla.org/attachment.cgi?id=8750017&action=diff#a/
> devtools/client/webconsole/test/browser_console_private_browsing.js_sec2
> 
> > ContentTask.spawn(gBrowser.selectedBrowser, null, function* () {
> >     content.console.log("bug874061-not-private");
> > });
> 
> why is this necessary?

There's the no-CPOWs-in-tests rules, which prevents you from using `content` without ContentTask, because it would be a CPOW otherwise (those frequently cause intermittents on e10s).
Attachment #8750017 - Flags: review?(jlaster) → review?(bgrinstead)
Comment on attachment 8750017 [details] [diff] [review]
0001-Bug-1256794-ESLint.patch

Review of attachment 8750017 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me
Attachment #8750017 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/ec97adea519b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.