Closed
Bug 1256794
Opened 8 years ago
Closed 8 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_private_browsing.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: linclark, Assigned: mkohler, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file)
2.95 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/browser_console_private_browsing.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → me
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f04f8c7322b1
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8750017 -
Flags: review?(jlaster)
Comment 3•8 years ago
|
||
Comment on attachment 8750017 [details] [diff] [review] 0001-Bug-1256794-ESLint.patch Review of attachment 8750017 [details] [diff] [review]: ----------------------------------------------------------------- https://bugzilla.mozilla.org/attachment.cgi?id=8750017&action=diff#a/devtools/client/webconsole/test/browser_console_private_browsing.js_sec2 > ContentTask.spawn(gBrowser.selectedBrowser, null, function* () { > content.console.log("bug874061-not-private"); > }); why is this necessary?
Comment 4•8 years ago
|
||
(In reply to Jason Laster [:jlast] from comment #3) > Comment on attachment 8750017 [details] [diff] [review] > 0001-Bug-1256794-ESLint.patch > > Review of attachment 8750017 [details] [diff] [review]: > ----------------------------------------------------------------- > > https://bugzilla.mozilla.org/attachment.cgi?id=8750017&action=diff#a/ > devtools/client/webconsole/test/browser_console_private_browsing.js_sec2 > > > ContentTask.spawn(gBrowser.selectedBrowser, null, function* () { > > content.console.log("bug874061-not-private"); > > }); > > why is this necessary? There's the no-CPOWs-in-tests rules, which prevents you from using `content` without ContentTask, because it would be a CPOW otherwise (those frequently cause intermittents on e10s).
Updated•8 years ago
|
Attachment #8750017 -
Flags: review?(jlaster) → review?(bgrinstead)
Comment 5•8 years ago
|
||
Comment on attachment 8750017 [details] [diff] [review] 0001-Bug-1256794-ESLint.patch Review of attachment 8750017 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me
Attachment #8750017 -
Flags: review?(bgrinstead) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ec97adea519b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/12f9bd2adb0e
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•