Closed Bug 1256800 Opened 4 years ago Closed 4 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_variables_view_highlighter.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: mkohler, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_variables_view_highlighter.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Assignee: nobody → me
Attachment #8748408 - Flags: review?(lclark)
Comment on attachment 8748408 [details] [diff] [review]
0001-Bug-1256800-ESLint.patch

Review of attachment 8748408 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8748408 - Flags: review?(lclark) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4200834d5011
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.