Closed Bug 1256887 Opened 4 years ago Closed 3 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_dont_navigate_on_doubleclick.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: linclark, Assigned: katharina.utecht, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_dont_navigate_on_doubleclick.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Attachment #8805753 - Flags: review?(lclark)
Assignee: nobody → katharina.utecht
Comment on attachment 8805753 [details] [diff] [review]
Changed aEvent to event

Review of attachment 8805753 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8805753 - Flags: review?(lclark) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47f503eacabd
"[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_dont_navigate_on_doubleclick.js". r=lclark
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/47f503eacabd
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.