Closed Bug 1256941 Opened 4 years ago Closed 3 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-file-location.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: linclark, Assigned: katika2987, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file, 2 obsolete files)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-file-location.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Attached patch 0001-Bug-1256941-ESLint.patch (obsolete) — Splinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=edf7fcb4edd0
Assignee: nobody → me
Status: NEW → ASSIGNED
Attachment #8750029 - Flags: review?(jlaster)
looks like dt8 is failing
Unfortunately, being realistic, I won't have time to finish this within the next few weeks. Therefore I'm un-assigning this again.
Assignee: me → nobody
Status: ASSIGNED → NEW
Kate is going to take this one.
Assignee: nobody → katika2987
Attached patch test-file-location.patch (obsolete) — Splinter Review
Attachment #8805748 - Attachment is obsolete: true
Comment on attachment 8805784 [details] [diff] [review]
fixed-eslint-test-file-location.patch

After a lot of testing, we found out that when "use strict" is added, it pushes the console lines a few lines below. On the browser_webconsole_bug_646025_console_file_location.js the messages were determined on the old lines. I updated those lines to the new ones.
Attachment #8805784 - Flags: review?(jlaster)
Comment on attachment 8805784 [details] [diff] [review]
fixed-eslint-test-file-location.patch

Review of attachment 8805784 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Kate, thanks for the patch!  This looks good to me, I'll go ahead and land it
Attachment #8805784 - Flags: review?(jlaster) → review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d643bbe83354
Fix ESLint issues in devtools/client/webconsole/test/test-file-location.js;r=bgrins
Mentor: jlaster, lclark → bgrinstead
Status: NEW → ASSIGNED
Attachment #8750029 - Attachment is obsolete: true
Attachment #8750029 - Flags: review?(jlaster)
OK, the code is now in an integration branch and will work its way through the system which will ultimately end up in this bug being resolved.

Thanks for contributing to Firefox!  If you are interested in fixing more DevTools bugs, we have a dashboard here for finding them: http://firefox-dev.tools/.
https://hg.mozilla.org/mozilla-central/rev/d643bbe83354
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.