Closed Bug 1256941 Opened 4 years ago Closed 3 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-file-location
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/test-file-location.js
Assignee: nobody → me
Status: NEW → ASSIGNED
Attachment #8750029 - Flags: review?(jlaster)
looks like dt8 is failing
Unfortunately, being realistic, I won't have time to finish this within the next few weeks. Therefore I'm un-assigning this again.
Assignee: me → nobody
Status: ASSIGNED → NEW
Kate is going to take this one.
Assignee: nobody → katika2987
Comment on attachment 8805784 [details] [diff] [review] fixed-eslint-test-file-location.patch After a lot of testing, we found out that when "use strict" is added, it pushes the console lines a few lines below. On the browser_webconsole_bug_646025_console_file_location.js the messages were determined on the old lines. I updated those lines to the new ones.
Attachment #8805784 - Flags: review?(jlaster)
Comment on attachment 8805784 [details] [diff] [review] fixed-eslint-test-file-location.patch Review of attachment 8805784 [details] [diff] [review]: ----------------------------------------------------------------- Hi Kate, thanks for the patch! This looks good to me, I'll go ahead and land it
Attachment #8805784 - Flags: review?(jlaster) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d643bbe83354 Fix ESLint issues in devtools/client/webconsole/test/test-file-location.js;r=bgrins
Mentor: jlaster, lclark → bgrinstead
Status: NEW → ASSIGNED
OK, the code is now in an integration branch and will work its way through the system which will ultimately end up in this bug being resolved. Thanks for contributing to Firefox! If you are interested in fixing more DevTools bugs, we have a dashboard here for finding them: http://firefox-dev.tools/.
You need to log in before you can comment on or make changes to this bug.