1256943 - BLOCKED_ON_PLUGIN_MODULE_INIT_MS is always 0 with e10s chrome

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This probe is valid for both chrome and content. The chrome case isn't working.
That's because we're accumulating the data in PluginModuleParent::NPP_NewInternal, but that won't be called in the chrome case.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

I also add some missing data to the content version, namely the duration of time that ContentParent::SendLoadPlugin takes.

Review commit: https://reviewboard.mozilla.org/r/40211/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40211/

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40211/diff/1-2/

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

https://reviewboard.mozilla.org/r/40211/#review36795

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c8ea88e6916

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c8ea88e6916

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

Approval Request Comment
[Feature/regressing bug #]: NPAPI plugin telemetry on e10s
[User impact if declined]: Inaccurate data on plugin jank when e10s is enabled, impairs our ability to make a correct decision.
[Describe test coverage new/current, TreeHerder]: Landed on m-c, tested locally by verifying that BLOCKED_ON_PLUGIN_MODULE_INIT_MS appears in about:telemetry for e10s chrome.
[Risks and why]: Low, very trivial change to telemetry probe
[String/UUID change made/needed]: None

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

Better telemetry for e10s/plugins sounds good to me. This should make it into the beta 4 build next Monday.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5e411e20a006

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2007655282c8