BLOCKED_ON_PLUGIN_MODULE_INIT_MS is always 0 with e10s chrome

RESOLVED FIXED in Firefox 46

Status

()

Core
Plug-ins
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(e10s+, firefox45 wontfix, firefox46 fixed, firefox47 fixed, firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This probe is valid for both chrome and content. The chrome case isn't working.
That's because we're accumulating the data in PluginModuleParent::NPP_NewInternal, but that won't be called in the chrome case.
(Assignee)

Comment 1

2 years ago
Created attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

I also add some missing data to the content version, namely the duration of time that ContentParent::SendLoadPlugin takes.

Review commit: https://reviewboard.mozilla.org/r/40211/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40211/
Attachment #8730875 - Flags: review?(jmathies)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40211/diff/1-2/
Attachment #8730875 - Attachment description: MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_INSTANCE_INIT_MS is being recorded in e10s chrome; r?jimm → MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm
Blocks: 1251551
status-firefox45: --- → wontfix
status-firefox46: --- → affected
status-firefox47: --- → affected
tracking-e10s: --- → +

Comment 3

2 years ago
Comment on attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

https://reviewboard.mozilla.org/r/40211/#review36795
Attachment #8730875 - Flags: review?(jmathies) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3c8ea88e6916
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
(Assignee)

Comment 6

2 years ago
Comment on attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

Approval Request Comment
[Feature/regressing bug #]: NPAPI plugin telemetry on e10s
[User impact if declined]: Inaccurate data on plugin jank when e10s is enabled, impairs our ability to make a correct decision.
[Describe test coverage new/current, TreeHerder]: Landed on m-c, tested locally by verifying that BLOCKED_ON_PLUGIN_MODULE_INIT_MS appears in about:telemetry for e10s chrome.
[Risks and why]: Low, very trivial change to telemetry probe
[String/UUID change made/needed]: None
Attachment #8730875 - Flags: approval-mozilla-beta?
Attachment #8730875 - Flags: approval-mozilla-aurora?
Comment on attachment 8730875 [details]
MozReview Request: Bug 1256943: Ensure that BLOCKED_ON_PLUGIN_MODULE_INIT_MS is being recorded in e10s chrome; r?jimm

Better telemetry for e10s/plugins sounds good to me. This should make it into the beta 4 build next Monday.
Attachment #8730875 - Flags: approval-mozilla-beta?
Attachment #8730875 - Flags: approval-mozilla-beta+
Attachment #8730875 - Flags: approval-mozilla-aurora?
Attachment #8730875 - Flags: approval-mozilla-aurora+

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e411e20a006
status-firefox47: affected → fixed

Comment 9

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/2007655282c8
status-firefox46: affected → fixed
You need to log in before you can comment on or make changes to this bug.