Closed Bug 1256973 Opened 4 years ago Closed 4 years ago

[refactor] Simplify assignment to result_callbacks

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: maja_zf, Assigned: nathalier, Mentored)

Details

(Keywords: pi-marionette-runner, Whiteboard: [lang=py][good first bug] )

Attachments

(1 file)

The intialization of result_callbals in BaseMarionetteTestRunner can be simplified to something like |self.result_callbacks = result_callbacks or []|

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette/runner/base.py#567
Hi! Could you please assign it to me?
Assignee: nobody → nathalier
Mentor: mjzffr
nathalier: If you append "r?REVIEWER", where REVIEWER is the nick of the module peer, MozReview will automatically request and assign the review to them.
Status: NEW → ASSIGNED
Thank you! It should be added to commit message, right?
(In reply to Nathalie Rud (:nathalier) from comment #4)
> Thank you! It should be added to commit message, right?

Yes, correct.  Make the first line of your commit message something like this:

    Bug 123456 - Short imperative message; r?mjzffr

    Longer commit message in prose goes here if needed.
Comment on attachment 8730951 [details]
MozReview Request: Bug 1256973. Simplify assignment to result_callbacks; r?maja_zf

https://reviewboard.mozilla.org/r/40261/#review37305

Hi Nathalie. This looks good. Please just push again with an commit message that mentions me as the reviewer.
Attachment #8730951 - Flags: review+
Comment on attachment 8730951 [details]
MozReview Request: Bug 1256973. Simplify assignment to result_callbacks; r?maja_zf

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40261/diff/1-2/
Attachment #8730951 - Attachment description: MozReview Request: Bug 1256973. Simplify assignment to result_callbacks → MozReview Request: Bug 1256973. Simplify assignment to result_callbacks; r?maja_zf
maja_zf: Corrected. Thank you
https://hg.mozilla.org/mozilla-central/rev/bf090da7e8f0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.