Closed
Bug 1256973
Opened 8 years ago
Closed 8 years ago
[refactor] Simplify assignment to result_callbacks
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: impossibus, Assigned: nathalier, Mentored)
Details
(Keywords: pi-marionette-runner, Whiteboard: [lang=py][good first bug] )
Attachments
(1 file)
The intialization of result_callbals in BaseMarionetteTestRunner can be simplified to something like |self.result_callbacks = result_callbacks or []| https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette/runner/base.py#567
Assignee | ||
Comment 1•8 years ago
|
||
Hi! Could you please assign it to me?
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → nathalier
Mentor: mjzffr
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40261/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40261/
Comment 3•8 years ago
|
||
nathalier: If you append "r?REVIEWER", where REVIEWER is the nick of the module peer, MozReview will automatically request and assign the review to them.
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•8 years ago
|
||
Thank you! It should be added to commit message, right?
Comment 5•8 years ago
|
||
(In reply to Nathalie Rud (:nathalier) from comment #4) > Thank you! It should be added to commit message, right? Yes, correct. Make the first line of your commit message something like this: Bug 123456 - Short imperative message; r?mjzffr Longer commit message in prose goes here if needed.
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8730951 [details] MozReview Request: Bug 1256973. Simplify assignment to result_callbacks; r?maja_zf https://reviewboard.mozilla.org/r/40261/#review37305 Hi Nathalie. This looks good. Please just push again with an commit message that mentions me as the reviewer.
Attachment #8730951 -
Flags: review+
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8730951 [details] MozReview Request: Bug 1256973. Simplify assignment to result_callbacks; r?maja_zf Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40261/diff/1-2/
Attachment #8730951 -
Attachment description: MozReview Request: Bug 1256973. Simplify assignment to result_callbacks → MozReview Request: Bug 1256973. Simplify assignment to result_callbacks; r?maja_zf
Assignee | ||
Comment 8•8 years ago
|
||
maja_zf: Corrected. Thank you
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bf090da7e8f0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•