Closed
Bug 1256978
Opened 8 years ago
Closed 8 years ago
[refactor] Use self.capabilities instead of self._capabilities where ever possible in BaseMarionetteTestRunner
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: impossibus, Assigned: nathalier, Mentored)
Details
(Keywords: pi-marionette-runner, Whiteboard: [lang=py][good first bug] )
Attachments
(1 file)
There's a property called "capabilities" in BaseMarionetteTestRunner. https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette/runner/base.py#642 However, in many places in BaseMarionetteTestRunner the underlying "hidden" attribute "self._capabilities" is used, thus not taking advantage of the property. For example: if self._capabilities['device'] == "desktop": should be if self.capabilities['device'] == 'desktop'
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40293/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40293/
Assignee | ||
Comment 2•8 years ago
|
||
Fixed. Only 2 places were found
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8730981 [details] MozReview Request: Bug 1256978. Use self.capabilities instead of self._capabilities in BaseMarionetteTestRunner; r?maja_zf Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40293/diff/1-2/
Attachment #8730981 -
Attachment description: MozReview Request: Bug 1256978. Use self.capabilities instead of self._capabilities in BaseMarionetteTestRunner → MozReview Request: Bug 1256978. Use self.capabilities instead of self._capabilities in BaseMarionetteTestRunner; r?maja_zf
Attachment #8730981 -
Flags: review?(mjzffr)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8730981 [details] MozReview Request: Bug 1256978. Use self.capabilities instead of self._capabilities in BaseMarionetteTestRunner; r?maja_zf Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40293/diff/2-3/
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → nathalier
Reporter | ||
Updated•8 years ago
|
Attachment #8730981 -
Flags: review?(mjzffr) → review+
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8730981 [details] MozReview Request: Bug 1256978. Use self.capabilities instead of self._capabilities in BaseMarionetteTestRunner; r?maja_zf https://reviewboard.mozilla.org/r/40293/#review37199
Reporter | ||
Comment 6•8 years ago
|
||
https://reviewboard.mozilla.org/r/40293/#review37199 Thanks for the quick fix, Nathalie. This looks good. I'll wait until tomorrow to see how test results turn out on try, although they look good so far, and then I'll land the commit for you on mozilla-inbound.
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5a19d947e016
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•