Closed
Bug 1256988
Opened 8 years ago
Closed 8 years ago
Move MOZ_WIDGET_TOOLKIT to Python configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: chmanchester, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(19 files)
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
chmanchester
:
review+
|
Details |
This unlocks a lot of other options. Moving --target in bug 1255305 helps.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 1•8 years ago
|
||
The default for MOZ_WIDGET_TOOLKIT depends on --target, which is available, but also on $gonkdir and MOZ_IOS, which aren't yet.
Depends on: 1250301
Assignee | ||
Comment 2•8 years ago
|
||
We can get away with just moving the --with-gonk and --with-ios-sdk options.
No longer depends on: 1250301
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2) > We can get away with just moving the --with-gonk and --with-ios-sdk options. To make things more explicit than the added dependency: in the end I'll be moving --with-gonk and changing the required --target for ios.
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40365/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40365/
Attachment #8731118 -
Flags: review?(cmanchester)
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40367/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40367/
Attachment #8731119 -
Flags: review?(cmanchester)
Assignee | ||
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40369/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40369/
Attachment #8731120 -
Flags: review?(cmanchester)
Assignee | ||
Comment 7•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40371/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40371/
Attachment #8731121 -
Flags: review?(cmanchester)
Assignee | ||
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40373/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40373/
Attachment #8731122 -
Flags: review?(cmanchester)
Assignee | ||
Comment 9•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40375/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40375/
Attachment #8731123 -
Flags: review?(cmanchester)
Assignee | ||
Comment 10•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40377/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40377/
Attachment #8731124 -
Flags: review?(cmanchester)
Assignee | ||
Comment 11•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40379/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40379/
Attachment #8731125 -
Flags: review?(cmanchester)
Assignee | ||
Comment 12•8 years ago
|
||
But only do that for the AC_SUBST. The AC_DEFINE is still useful. Review commit: https://reviewboard.mozilla.org/r/40381/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40381/
Attachment #8731126 -
Flags: review?(cmanchester)
Assignee | ||
Comment 13•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40383/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40383/
Attachment #8731127 -
Flags: review?(cmanchester)
Assignee | ||
Comment 14•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40385/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40385/
Attachment #8731128 -
Flags: review?(cmanchester)
Assignee | ||
Comment 15•8 years ago
|
||
It hasn't done anything since bug 191447, 13 years ago Review commit: https://reviewboard.mozilla.org/r/40387/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40387/
Attachment #8731129 -
Flags: review?(cmanchester)
Assignee | ||
Comment 16•8 years ago
|
||
Now that the MOZ_WIDGET_TOOLKIT test is in moz.configure, the value for MOZ_WIDGET_TOOLKIT is now set in old-configure.in very early, which now allows to check for its value before doing to Xt test instead of resetting XT_LIBS later. Review commit: https://reviewboard.mozilla.org/r/40389/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40389/
Attachment #8731130 -
Flags: review?(cmanchester)
Assignee | ||
Comment 17•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40391/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40391/
Attachment #8731131 -
Flags: review?(cmanchester)
Assignee | ||
Comment 18•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40393/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40393/
Attachment #8731132 -
Flags: review?(cmanchester)
Assignee | ||
Comment 19•8 years ago
|
||
Remove the AC_DEFINE because it is unused. Review commit: https://reviewboard.mozilla.org/r/40395/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40395/
Attachment #8731133 -
Flags: review?(cmanchester)
Assignee | ||
Comment 20•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40397/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40397/
Attachment #8731134 -
Flags: review?(cmanchester)
Assignee | ||
Comment 21•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40399/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40399/
Attachment #8731135 -
Flags: review?(cmanchester)
Assignee | ||
Comment 22•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40401/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40401/
Attachment #8731136 -
Flags: review?(cmanchester)
Assignee | ||
Comment 23•8 years ago
|
||
Note all these patches are not directly about MOZ_WIDGET_TOOLKIT, but they are related to the first block of MOZ_WIDGET_TOOLKIT, and I didn't feel like multipying bugs.
Comment 24•8 years ago
|
||
https://reviewboard.mozilla.org/r/40367/#review36895 ::: toolkit/moz.configure:20 (Diff revision 1) > +# `choices` depending on the target, but that doesn't pan out for the same > +# reason. > +option('--enable-default-toolkit', nargs=1, > + choices=('cairo-windows', 'cairo-gtk2', 'cairo-gtk2-x11', 'cairo-gtk3', > + 'cairo-qt', 'cairo-cocoa', 'cairo-uikit', 'cairo-android', > + 'cairo-gonk'), help='Select default toolkit') Move `help=` to the next line? This formatting is a little confusing. ::: toolkit/moz.configure:26 (Diff revision 1) > + > +@depends('--enable-default-toolkit', target, gonkdir) > +def toolkit(value, target, gonkdir): > + # Define possible choices for each platform. The default is the first one > + # listed when there are several. > + os = target.os Remove or use in the if-else chain.
Comment 25•8 years ago
|
||
https://reviewboard.mozilla.org/r/40397/#review36897 ::: toolkit/moz.configure:128 (Diff revision 1) > +option(env='MOZ_INSTRUMENT_EVENT_LOOP', > + help='Force-enable event loop instrumentation') > + > +@depends('MOZ_INSTRUMENT_EVENT_LOOP', toolkit) > +def instrument_event_loop(value, toolkit): > + if value or toolkit in ('windows', 'gtk2', 'gtk3', 'cocoa', 'android', Parens would help me understand the operator precedence here. Also, is `value.origin` safe eve n if `not value`?
Comment 26•8 years ago
|
||
https://reviewboard.mozilla.org/r/40399/#review36899 ::: toolkit/moz.configure:141 (Diff revision 1) > +option(env='USE_FC_FREETYPE', > + help='Force-enable the use of fontconfig freetype') > + > +@depends('USE_FC_FREETYPE', toolkit) > +def fc_freetype(value, toolkit): > + if (value or toolkit in ('gtk2', 'gtk3', 'qt') and Same question here.
Assignee | ||
Comment 27•8 years ago
|
||
https://reviewboard.mozilla.org/r/40367/#review36895 > Remove or use in the if-else chain. It *is* used.
Assignee | ||
Comment 28•8 years ago
|
||
https://reviewboard.mozilla.org/r/40397/#review36897 > Parens would help me understand the operator precedence here. Also, is `value.origin` safe eve n if `not value`? value is not a bool.
Assignee | ||
Comment 29•8 years ago
|
||
Comment on attachment 8731118 [details] MozReview Request: Bug 1256988 - Move --with-gonk to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40365/diff/1-2/
Assignee | ||
Comment 30•8 years ago
|
||
Comment on attachment 8731119 [details] MozReview Request: Bug 1256988 - Move MOZ_WIDGET_TOOLKIT to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40367/diff/1-2/
Assignee | ||
Comment 31•8 years ago
|
||
Comment on attachment 8731120 [details] MozReview Request: Bug 1256988 - Replace tests on MOZ_ENABLE_GTK2 with tests on MOZ_WIDGET_TOOLKIT==gtk2 Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40369/diff/1-2/
Assignee | ||
Comment 32•8 years ago
|
||
Comment on attachment 8731121 [details] MozReview Request: Bug 1256988 - Replace tests on MOZ_ENABLE_GTK3 with tests on MOZ_WIDGET_TOOLKIT==gtk3 Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40371/diff/1-2/
Assignee | ||
Comment 33•8 years ago
|
||
Comment on attachment 8731122 [details] MozReview Request: Bug 1256988 - Replace tests on MOZ_ENABLE_GTK with tests on MOZ_WIDGET_TOOLKIT containing gtk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40373/diff/1-2/
Assignee | ||
Comment 34•8 years ago
|
||
Comment on attachment 8731123 [details] MozReview Request: Bug 1256988 - Remove duplicate gfx.content.azure.backends settings in all.js Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40375/diff/1-2/
Assignee | ||
Comment 35•8 years ago
|
||
Comment on attachment 8731124 [details] MozReview Request: Bug 1256988 - Fix #endif comments for MOZ_WIDGET_GTK Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40377/diff/1-2/
Assignee | ||
Comment 36•8 years ago
|
||
Comment on attachment 8731125 [details] MozReview Request: Bug 1256988 - Remove MOZ_WIDGET_GTK2 define Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40379/diff/1-2/
Assignee | ||
Comment 37•8 years ago
|
||
Comment on attachment 8731126 [details] MozReview Request: Bug 1256988 - Replace tests on MOZ_WIDGET_GTK with tests on MOZ_WIDGET_TOOLKIT containing gtk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40381/diff/1-2/
Assignee | ||
Comment 38•8 years ago
|
||
Comment on attachment 8731127 [details] MozReview Request: Bug 1256988 - Move MOZ_WIDGET_* defines to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40383/diff/1-2/
Assignee | ||
Comment 39•8 years ago
|
||
Comment on attachment 8731128 [details] MozReview Request: Bug 1256988 - Remove useless Gtk/accessibility check in js/src/old-configure.in Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40385/diff/1-2/
Assignee | ||
Comment 40•8 years ago
|
||
Comment on attachment 8731129 [details] MozReview Request: Bug 1256988 - Remove NO_X11 Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40387/diff/1-2/
Assignee | ||
Comment 41•8 years ago
|
||
Comment on attachment 8731130 [details] MozReview Request: Bug 1256988 - Skip the Xt library test for MOZ_WIDGET_TOOLKIT==qt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40389/diff/1-2/
Assignee | ||
Comment 42•8 years ago
|
||
Comment on attachment 8731131 [details] MozReview Request: Bug 1256988 - Move X11 and MOZ_WIDGET_TOOLKIT-related things to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40391/diff/1-2/
Assignee | ||
Comment 43•8 years ago
|
||
Comment on attachment 8731132 [details] MozReview Request: Bug 1256988 - Move --with-gl-provider to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40393/diff/1-2/
Assignee | ||
Comment 44•8 years ago
|
||
Comment on attachment 8731133 [details] MozReview Request: Bug 1256988 - Move MOZ_PDF_PRINTING to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40395/diff/1-2/
Assignee | ||
Comment 45•8 years ago
|
||
Comment on attachment 8731134 [details] MozReview Request: Bug 1256988 - Move MOZ_INSTRUMENT_EVENT_LOOP to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40397/diff/1-2/
Assignee | ||
Comment 46•8 years ago
|
||
Comment on attachment 8731135 [details] MozReview Request: Bug 1256988 - Move USE_FC_FREETYPE to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40399/diff/1-2/
Assignee | ||
Comment 47•8 years ago
|
||
Comment on attachment 8731136 [details] MozReview Request: Bug 1256988 - Remove MOZ_TOUCH, nothing is using it Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40401/diff/1-2/
Assignee | ||
Comment 48•8 years ago
|
||
Comment on attachment 8731133 [details] MozReview Request: Bug 1256988 - Move MOZ_PDF_PRINTING to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40395/diff/2-3/
Assignee | ||
Comment 49•8 years ago
|
||
Comment on attachment 8731134 [details] MozReview Request: Bug 1256988 - Move MOZ_INSTRUMENT_EVENT_LOOP to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40397/diff/2-3/
Assignee | ||
Comment 50•8 years ago
|
||
Comment on attachment 8731135 [details] MozReview Request: Bug 1256988 - Move USE_FC_FREETYPE to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40399/diff/2-3/
Assignee | ||
Comment 51•8 years ago
|
||
Comment on attachment 8731136 [details] MozReview Request: Bug 1256988 - Remove MOZ_TOUCH, nothing is using it Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40401/diff/2-3/
Reporter | ||
Updated•8 years ago
|
Attachment #8731118 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 52•8 years ago
|
||
Comment on attachment 8731118 [details] MozReview Request: Bug 1256988 - Move --with-gonk to moz.configure https://reviewboard.mozilla.org/r/40365/#review36999
Reporter | ||
Comment 53•8 years ago
|
||
Comment on attachment 8731119 [details] MozReview Request: Bug 1256988 - Move MOZ_WIDGET_TOOLKIT to moz.configure https://reviewboard.mozilla.org/r/40367/#review37003
Attachment #8731119 -
Flags: review?(cmanchester) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8731120 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 54•8 years ago
|
||
Comment on attachment 8731120 [details] MozReview Request: Bug 1256988 - Replace tests on MOZ_ENABLE_GTK2 with tests on MOZ_WIDGET_TOOLKIT==gtk2 https://reviewboard.mozilla.org/r/40369/#review37005
Reporter | ||
Updated•8 years ago
|
Attachment #8731121 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 55•8 years ago
|
||
Comment on attachment 8731121 [details] MozReview Request: Bug 1256988 - Replace tests on MOZ_ENABLE_GTK3 with tests on MOZ_WIDGET_TOOLKIT==gtk3 https://reviewboard.mozilla.org/r/40371/#review37007
Reporter | ||
Comment 56•8 years ago
|
||
Comment on attachment 8731122 [details] MozReview Request: Bug 1256988 - Replace tests on MOZ_ENABLE_GTK with tests on MOZ_WIDGET_TOOLKIT containing gtk https://reviewboard.mozilla.org/r/40373/#review37009 ::: accessible/atk/moz.build:46 (Diff revision 2) > '/other-licenses/atk-1.0', > ] > > FINAL_LIBRARY = 'xul' > > -if CONFIG['MOZ_ENABLE_GTK']: > +if 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']: Should this be "startswith" throughout? I guess it probably doesn't matter.
Attachment #8731122 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 57•8 years ago
|
||
Comment on attachment 8731123 [details] MozReview Request: Bug 1256988 - Remove duplicate gfx.content.azure.backends settings in all.js https://reviewboard.mozilla.org/r/40375/#review37017 It might be helpful to add a note in the commit message that these checks are unecessary because the #else above them.
Attachment #8731123 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 58•8 years ago
|
||
Comment on attachment 8731124 [details] MozReview Request: Bug 1256988 - Fix #endif comments for MOZ_WIDGET_GTK https://reviewboard.mozilla.org/r/40377/#review37019
Attachment #8731124 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 59•8 years ago
|
||
Comment on attachment 8731125 [details] MozReview Request: Bug 1256988 - Remove MOZ_WIDGET_GTK2 define https://reviewboard.mozilla.org/r/40379/#review37021
Attachment #8731125 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 60•8 years ago
|
||
Comment on attachment 8731126 [details] MozReview Request: Bug 1256988 - Replace tests on MOZ_WIDGET_GTK with tests on MOZ_WIDGET_TOOLKIT containing gtk https://reviewboard.mozilla.org/r/40381/#review37055
Attachment #8731126 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 61•8 years ago
|
||
Comment on attachment 8731127 [details] MozReview Request: Bug 1256988 - Move MOZ_WIDGET_* defines to moz.configure https://reviewboard.mozilla.org/r/40383/#review37061
Attachment #8731127 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 62•8 years ago
|
||
Comment on attachment 8731128 [details] MozReview Request: Bug 1256988 - Remove useless Gtk/accessibility check in js/src/old-configure.in https://reviewboard.mozilla.org/r/40385/#review37063
Attachment #8731128 -
Flags: review?(cmanchester) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8731129 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 63•8 years ago
|
||
Comment on attachment 8731129 [details] MozReview Request: Bug 1256988 - Remove NO_X11 https://reviewboard.mozilla.org/r/40387/#review37071
Reporter | ||
Comment 64•8 years ago
|
||
Comment on attachment 8731130 [details] MozReview Request: Bug 1256988 - Skip the Xt library test for MOZ_WIDGET_TOOLKIT==qt https://reviewboard.mozilla.org/r/40389/#review37077 ::: old-configure.in:3454 (Diff revision 2) > MOZ_ENABLE_QT=1 > if test -z "$WITHOUT_X11"; then > MOZ_ENABLE_XREMOTE=1 > MOZ_GL_DEFAULT_PROVIDER=GLX > MOZ_X11=1 > AC_DEFINE(MOZ_X11) > - XT_LIBS= > fi So if we have MOZ_WIDGET_TOOLKIT == qt, and WITHOUT_X11, XT_LIBS would possibly be non-empty before, but it's never set now when MOZ_WIDGET_TOOLKIT == qt. I'm trusting this is either impossible, or unimportant.
Attachment #8731130 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 65•8 years ago
|
||
Comment on attachment 8731131 [details] MozReview Request: Bug 1256988 - Move X11 and MOZ_WIDGET_TOOLKIT-related things to moz.configure https://reviewboard.mozilla.org/r/40391/#review37079 ::: old-configure.in:2112 (Diff revision 2) > dnl ======================================================== > dnl Checks for X libraries. > dnl Ordering is important. > dnl Xt is dependent upon SM as of X11R6 > dnl ======================================================== > -if test "$no_x" != "yes"; then > +if test -n "$MOZ_X11"; then Glad to get rid of this double negative!
Attachment #8731131 -
Flags: review?(cmanchester) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8731132 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 66•8 years ago
|
||
Comment on attachment 8731132 [details] MozReview Request: Bug 1256988 - Move --with-gl-provider to moz.configure https://reviewboard.mozilla.org/r/40393/#review37081
Reporter | ||
Comment 67•8 years ago
|
||
Comment on attachment 8731133 [details] MozReview Request: Bug 1256988 - Move MOZ_PDF_PRINTING to moz.configure https://reviewboard.mozilla.org/r/40395/#review37085
Attachment #8731133 -
Flags: review?(cmanchester) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8731134 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 68•8 years ago
|
||
Comment on attachment 8731134 [details] MozReview Request: Bug 1256988 - Move MOZ_INSTRUMENT_EVENT_LOOP to moz.configure https://reviewboard.mozilla.org/r/40397/#review37091
Reporter | ||
Comment 69•8 years ago
|
||
Comment on attachment 8731135 [details] MozReview Request: Bug 1256988 - Move USE_FC_FREETYPE to moz.configure https://reviewboard.mozilla.org/r/40399/#review37093
Attachment #8731135 -
Flags: review?(cmanchester) → review+
Reporter | ||
Comment 70•8 years ago
|
||
Comment on attachment 8731136 [details] MozReview Request: Bug 1256988 - Remove MOZ_TOUCH, nothing is using it https://reviewboard.mozilla.org/r/40401/#review37095
Attachment #8731136 -
Flags: review?(cmanchester) → review+
Assignee | ||
Comment 71•8 years ago
|
||
(In reply to Chris Manchester (:chmanchester) from comment #64) > So if we have MOZ_WIDGET_TOOLKIT == qt, and WITHOUT_X11, XT_LIBS would > possibly be non-empty before, but it's never set now when MOZ_WIDGET_TOOLKIT > == qt. > > I'm trusting this is either impossible, or unimportant. Looking at the intent declared in the code flow in old-configure.in, XT_LIBS is only supposed to be set when X11 is enabled. My thought is that it's a flaw in the logic that disabling X11 was done after XT_LIBS was set from code that's supposed to be skipped if X11 is disabled. If that happens to break building Qt without X, people interested in that configuration will file a bug.
Assignee | ||
Comment 72•8 years ago
|
||
https://reviewboard.mozilla.org/r/40373/#review37009 > Should this be "startswith" throughout? I guess it probably doesn't matter. I pondered about it, but I went with the shorter one.
Comment 73•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f11a8d6f0955 https://hg.mozilla.org/integration/mozilla-inbound/rev/a5612f0dcf2a https://hg.mozilla.org/integration/mozilla-inbound/rev/618a66810a89 https://hg.mozilla.org/integration/mozilla-inbound/rev/32cdb06f0d17 https://hg.mozilla.org/integration/mozilla-inbound/rev/9a143b863326 https://hg.mozilla.org/integration/mozilla-inbound/rev/9d3e4a889305 https://hg.mozilla.org/integration/mozilla-inbound/rev/9a76087f0451 https://hg.mozilla.org/integration/mozilla-inbound/rev/9f309469edf4 https://hg.mozilla.org/integration/mozilla-inbound/rev/5d3e4758be9d https://hg.mozilla.org/integration/mozilla-inbound/rev/0acd12e7da2a https://hg.mozilla.org/integration/mozilla-inbound/rev/0d152cfe1c27 https://hg.mozilla.org/integration/mozilla-inbound/rev/0e03188f3d58 https://hg.mozilla.org/integration/mozilla-inbound/rev/63064e69b81e https://hg.mozilla.org/integration/mozilla-inbound/rev/730733acaf71 https://hg.mozilla.org/integration/mozilla-inbound/rev/b1a590ee3dfd https://hg.mozilla.org/integration/mozilla-inbound/rev/600221f803d0 https://hg.mozilla.org/integration/mozilla-inbound/rev/d9033dd5e311 https://hg.mozilla.org/integration/mozilla-inbound/rev/a022db693cc5 https://hg.mozilla.org/integration/mozilla-inbound/rev/fd2d468f0ee8
Comment 74•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f11a8d6f0955 https://hg.mozilla.org/mozilla-central/rev/a5612f0dcf2a https://hg.mozilla.org/mozilla-central/rev/618a66810a89 https://hg.mozilla.org/mozilla-central/rev/32cdb06f0d17 https://hg.mozilla.org/mozilla-central/rev/9a143b863326 https://hg.mozilla.org/mozilla-central/rev/9d3e4a889305 https://hg.mozilla.org/mozilla-central/rev/9a76087f0451 https://hg.mozilla.org/mozilla-central/rev/9f309469edf4 https://hg.mozilla.org/mozilla-central/rev/5d3e4758be9d https://hg.mozilla.org/mozilla-central/rev/0acd12e7da2a https://hg.mozilla.org/mozilla-central/rev/0d152cfe1c27 https://hg.mozilla.org/mozilla-central/rev/0e03188f3d58 https://hg.mozilla.org/mozilla-central/rev/63064e69b81e https://hg.mozilla.org/mozilla-central/rev/730733acaf71 https://hg.mozilla.org/mozilla-central/rev/b1a590ee3dfd https://hg.mozilla.org/mozilla-central/rev/600221f803d0 https://hg.mozilla.org/mozilla-central/rev/d9033dd5e311 https://hg.mozilla.org/mozilla-central/rev/a022db693cc5 https://hg.mozilla.org/mozilla-central/rev/fd2d468f0ee8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•