12570 - Mult accts dies when no preferences

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Phil Peterson]

So, I ran a clobber build, which kills everything in dist, including the
profiles. So I started with no profile and no prefs, and died with this stack
trace:

NTDLL! 77f7629c()
nsDebug::PreCondition(const char * 0x6036b36c
??_C@_0DJ@KMGL@You?5can?8t?5dereference?5a?5NULL?5nsC@, const char * 0x6036b3a8
??_C@_0N@NHHF@mRawPtr?5?$CB?$DN?50?$AA@, const char * 0x6036b3b8
??_C@_0CB@MCGB@?4?4?2?4?4?2?4?4?2dist?2include?2nsCOMPtr?4h@, int 0x0000024c)
line 152 + 13 bytes
nsCOMPtr<nsISupportsArray>::operator->() line 588 + 34 bytes
nsMsgAccount::AddIdentity(nsMsgAccount * const 0x019870c0, nsIMsgIdentity *
0x01987700) line 364 + 15 bytes
nsMsgAccountManager::MigratePopAccounts(nsIMsgIdentity * 0x01987700) line 1166
nsMsgAccountManager::upgradePrefs() line 1087 + 23 bytes
nsMsgAccountManager::LoadAccounts(nsMsgAccountManager * const 0x01987960) line
791 + 8 bytes
nsMsgMailSession::GetAccountManager(nsMsgMailSession * const 0x01987b90,
nsIMsgAccountManager * * 0x0012f1f8) line 132
nsMsgMailSession::GetCurrentServer(nsMsgMailSession * const 0x01987b90,
nsIMsgIncomingServer * * 0x0012f25c) line 105 + 36 bytes
nsMessenger::InitializeFolderRoot() line 352 + 36 bytes
nsMessenger::nsMessenger() line 187
NS_NewMessenger(const nsID & {...}, void * * 0x0012f368) line 264 + 27 bytes
nsMsgFactory::CreateInstance(nsMsgFactory * const 0x01987e70, nsISupports *
0x00000000, const nsID & {...}, void * * 0x0012f368) line 229 + 13 bytes
nsComponentManagerImpl::CreateInstance(nsComponentManagerImpl * const
0x00924b60, const nsID & {...}, nsISupports * 0x00000000, const nsID & {...},
void * * 0x0012f368) line 1398 + 24 bytes
nsComponentManager::CreateInstance(const nsID & {...}, nsISupports * 0x00000000,
const nsID & {...}, void * * 0x0012f368) line 78
CIDCreateInstance::Call(CIDCreateInstance * const 0x01986270, JSContext *
0x017a4960, JSObject * 0x00a6ac10, unsigned int 0x00000000, long * 0x00a700a4,
long * 0x0012f484, nsIXPConnectWrappedNative * 0x01987fc0, nsIXPCScriptable *
0x0175c400, int * 0x0012f3b4) line 642 + 20 bytes
WrappedNative_Call(JSContext * 0x017a4960, JSObject * 0x00a6ac10, unsigned int
0x00000000, long * 0x00a700a4, long * 0x0012f484) line 525 + 44 bytes
js_Invoke(JSContext * 0x017a4960, unsigned int 0x00000000, unsigned int
0x00000000) line 654 + 26 bytes
js_Interpret(JSContext * 0x017a4960, long * 0x0012fccc) line 2228 + 15 bytes
js_Execute(JSContext * 0x017a4960, JSObject * 0x00a5fbd8, JSScript * 0x01985130,
JSFunction * 0x00000000, JSStackFrame * 0x00000000, int 0x00000000, long *
0x0012fccc) line 827 + 13 bytes
JS_EvaluateUCScriptForPrincipals(JSContext * 0x017a4960, JSObject * 0x00a5fbd8,
JSPrincipals * 0x01971d50, const unsigned short * 0x00a9fd50, unsigned int
0x00003e4b, const char * 0x01971de0, unsigned int 0x00000000, long * 0x0012fccc)
line 2596 + 27 bytes
nsJSContext::EvaluateString(nsJSContext * const 0x017a4ad0, const nsString &
{...}, const char * 0x01971de0, unsigned int 0x00000000, nsString & {...}, int *
0x0012fcf4) line 163 + 66 bytes
XULContentSinkImpl::EvaluateScript(nsString & {...}, unsigned int 0x00000000)
line 1729
XULContentSinkImpl::DoneLoadingScript(nsIUnicharStreamLoader * 0x01970700,
nsString & {...}, void * 0x017a0a80, unsigned int 0x00000000) line 1679
nsUnicharStreamLoader::OnStopRequest(nsUnicharStreamLoader * const 0x01970704,
nsIChannel * 0x01971ab0, nsISupports * 0x00000000, unsigned int 0x00000000,
const unsigned short * 0x00000000) line 159 + 31 bytes
nsOnStopRequestEvent::HandleEvent(nsOnStopRequestEvent * const 0x019711d0) line
269
nsStreamListenerEvent::HandlePLEvent(PLEvent * 0x019711d4) line 144 + 12 bytes
PL_HandleEvent(PLEvent * 0x019711d4) line 509 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x009c65d0) line 470 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x3cda00b4, unsigned int 0x0000c0f7, unsigned int
0x00000000, long 0x009c65d0) line 938 + 9 bytes
USER32! 77e71820()
009c65d0()

Comment 1

[Alec Flett]

this is bad. must fix soon.
I think the fix is really easy.

Comment 2

[Alec Flett]

seth is actually fixing this for his pref migration code.
Thanks seth!

Comment 3

[(not reading, please use [e-mail] instead)]

got the fix in hand.

(migrating prefs were broken too.)

accepting.

Comment 4

[(not reading, please use [e-mail] instead)]

fixed.

Comment 5

[Ninoschka Baca]

Build 1999090208M10: Win32/NT4, Mac 8.5.1, Build 1999090108M10: Linux/Redhat 6.0
Verified Fixed.

I renamed the registry and prefs.js files. Launched Mail and in all cases the
Profile Manager appears, I can progress through the dialogs and Mail starts
without crashing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5358e66ba432
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12570 - Correctly removes search suggestions when search query and url is empty